Skip to content

Commit

Permalink
Refactored build properties
Browse files Browse the repository at this point in the history
- Removed a redundant PropertyGroup
- Moved the NoWarn property for NU5104 warning to the ES.FX projects' PropertyGroup
- Reorganized comments for better readability and understanding of code
  • Loading branch information
winromulus committed Jun 15, 2024
1 parent f26be7b commit ae1e5bf
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,17 @@
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<!--<PackageOutputPath>$(PackageOutputDir)</PackageOutputPath>-->
</PropertyGroup>

<PropertyGroup>
<!-- Don't warn about "A stable release of a package should not have a prerelease dependency." -->
<NoWarn>$(NoWarn);NU5104</NoWarn>
</PropertyGroup>

<PropertyGroup>
<!-- Default to false; specific projects will override to true -->
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
</PropertyGroup>

<!-- ES.FX Projects should build packages -->
<PropertyGroup Condition="'$(MSBuildProjectName)' == '' Or $(MSBuildProjectName.StartsWith('ES.FX'))">
<!-- ES.FX Projects should build packages -->
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<!-- Don't warn about "A stable release of a package should not have a prerelease dependency." -->
<NoWarn>$(NoWarn);NU5104</NoWarn>
</PropertyGroup>

<!--Test projects-->
Expand Down

0 comments on commit ae1e5bf

Please sign in to comment.