Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The highly dreaded roles rename #7

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

The highly dreaded roles rename #7

wants to merge 18 commits into from

Conversation

Monotheonist
Copy link
Contributor

About the PR

Renamed the things that are outlined as having different names in The Station.

Why / Balance

Because lore 😎

Technical details

Does the following:

  • Edits upstream YAML for at least a few lines. I'm probably missing some. If you catch it, let me know.
  • Touches upstream locale files because the VSCode fluent extension fucking shat itself.
  • Overrides a lot of the item of the locale for Captain, HoP, Detective, and Chemist (which I barely touched because I'm asking myself if I really wanna do Chemistry -> Pharmacy (and so is Milon apparently.) If I missed things, PR it, it's really a bang up job. There will be mistakes.
  • Adds access localizations for this
  • Adds job name and timer locale
  • Adds supervisor name changes
  • Adds custom descriptions for at least too jobs.
    Holy fuck, it's all Fluent! So much fucking FLUENT!! AAAAAAAAAAAAAAAAAAAAAAAAAAA!!!

Media

  • I have added media to this PR or it does not require an ingame showcase. (It works properly. That's all you need to know)

@Monotheonist Monotheonist requested review from a team as code owners December 28, 2024 21:59
@github-actions github-actions bot added size/M 100-999 lines S: Needs Review Changes: YML Changes any yml files Changes: Localization Changes any ftl files and removed S: Needs Review labels Dec 28, 2024
@Monotheonist
Copy link
Contributor Author

(I forgot the play-time trackers, so don't merge this.)

MilonPL
MilonPL requested changes Dec 28, 2024
View reviewed changes
Copy link
Collaborator

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(there were in fact more items mentioning the detective)

Resources/Locale/en-US/emberfall/job/job-item-overrides.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/devices/device-network.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/devices/device-network.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/game-ticking/game-rules/gamerule-admin.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/revenant/revenant.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/weapons/melee/melee.ftl Outdated Show resolved Hide resolved
@Monotheonist
Copy link
Contributor Author

Once again I am realistically forgetting a lot of items (I have to address figurines at some point.)

@Monotheonist
Copy link
Contributor Author

How I feel after getting past the goddamn yaml linter
image

@Monotheonist Monotheonist requested a review from MilonPL December 29, 2024 06:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 7, 2025
@MilonPL
Copy link
Collaborator

MilonPL commented Jan 7, 2025

damnation

MilonPL pushed a commit that referenced this pull request Jan 19, 2025
@juliangiebel @MilonPL
Adds omnisexual pin (#34439)
7ce9346 
* Make important change (#7)

This is to help julian test his bot

* Omnibus

* Remove random test file from testing a gh bot

* Add pin to vendor, spawners and loadout

---------

Co-authored-by: nikthechampiongr <[email protected]>
(cherry picked from commit a967fc748613fd34a9f6144ef6f702e30fb4f1a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilonPL MilonPL Awaiting requested review from MilonPL

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Merge Conflict Fix your PR! S: Needs Review size/M 100-999 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Monotheonist @MilonPL