Troubleshoot windows failure with new URL

Must use `fileURLToPath` to convert properly back from URL into a path.
ember-template-lint · Nov 4, 2021 · d320e2b · d320e2b
1 parent e02b20c
commit d320e2b
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 16 deletions.
diff --git a/src/bin.test.ts b/src/bin.test.ts
@@ -1,12 +1,18 @@
 import { existsSync } from 'fs';
+import { fileURLToPath } from 'url';
 import execa from 'execa';
 import { join } from 'path';
 import { createTempDir, TempDir } from 'broccoli-test-helper';
 import slash from 'slash';
 
-const COMPILED_BIN_PATH = new URL('./bin.js', import.meta.url).pathname;
+const COMPILED_BIN_PATH = fileURLToPath(new URL('./bin.js', import.meta.url));
+
 if (!existsSync(COMPILED_BIN_PATH)) {
-  throw new Error('Missing compiled output, run `yarn build`!');
+  throw new Error(
+    `Missing compiled output, run \`yarn build\`! Looked at ${COMPILED_BIN_PATH} (based on ${
+      import.meta.url
+    })`
+  );
 }
 
 function run(args: string[], cwd: string) {

diff --git a/src/bin.ts b/src/bin.ts
@@ -4,6 +4,7 @@ import * as os from 'os';
 import { readFileSync } from 'fs';
 import { program } from 'commander';
 import run from './runner.js';
+import { pathToFileURL } from 'url';
 
 const version = JSON.parse(
   readFileSync(new URL('../package.json', import.meta.url), { encoding: 'utf-8' })
@@ -36,5 +37,6 @@ if (program.args.length < 1 || !programOptions.transform) {
     silent: programOptions.silent,
   };
 
-  run(programOptions.transform, program.args, options);
+  const transformPath = pathToFileURL(programOptions.transform);
+  run(transformPath, program.args, options);
 }
diff --git a/src/runner.ts b/src/runner.ts
@@ -12,7 +12,8 @@ import workerpool from 'workerpool';
 
 tmp.setGracefulCleanup();
 
-const WORKER_URL = new URL('./worker.js', import.meta.url);
+import { fileURLToPath } from 'url';
+const WORKER_PATH = fileURLToPath(new URL('./worker.js', import.meta.url));
 
 class NoFilesError extends Error {}
 
@@ -121,7 +122,7 @@ class StatsCollector {
 }
 
 export default async function run(
-  transformFile: string,
+  transformFile: URL,
   filePaths: string[],
   options: { silent?: boolean; cpus: number }
 ): Promise<void> {
@@ -151,11 +152,11 @@ export default async function run(
 /**
  * Returns the location of the transform module on disk.
  */
-async function loadTransform(transformFile: string): Promise<string> {
-  const isRemote = transformFile.startsWith('http');
+async function loadTransform(transformFile: URL): Promise<string> {
+  const isLocal = transformFile.protocol === 'file:';
 
-  if (!isRemote) {
-    return resolve(process.cwd(), transformFile);
+  if (isLocal) {
+    return fileURLToPath(transformFile);
   }
 
   const contents = await downloadFile(transformFile);
@@ -166,9 +167,9 @@ async function loadTransform(transformFile: string): Promise<string> {
   return filePath.name;
 }
 
-function downloadFile(url: string): Promise<string> {
+function downloadFile(url: URL): Promise<string> {
   return new Promise((resolve, reject) => {
-    const transport = url.startsWith('https') ? https : http;
+    const transport = url.protocol === 'https:' ? https : http;
 
     let contents = '';
     transport
@@ -221,7 +222,7 @@ async function spawnWorkers(
 
   logger.spin('Processed 0 files');
 
-  const pool = workerpool.pool(WORKER_URL.pathname, { maxWorkers: cpus });
+  const pool = workerpool.pool(WORKER_PATH, { maxWorkers: cpus });
 
   let i = 0;
   const worker = (queue as any).async.asyncify(async (file: string) => {
@@ -240,13 +241,14 @@ async function spawnWorkers(
 
 function handleError(err: any, logger: Logger): void {
   if (err.code === 'MODULE_NOT_FOUND') {
-    logger.error('Transform plugin not found');
+    logger.error(`Transform plugin not found`);
   } else if (err instanceof NoFilesError) {
     logger.error('No files matched');
   } else {
     logger.error(err);
-    if (err.stack) {
-      logger.error(err.stack);
-    }
+  }
+
+  if (err.stack) {
+    logger.error(err.stack);
   }
 }