This repository has been archived by the owner on Jun 13, 2019. It is now read-only.
Remove bower content in update install releases #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Oct 17, 2017
| @@ -7,5 +7,5 @@ export default { | |||
| enableTestURL: true, | |||
| debugFileName: ".debug.js", | |||
| ignoreFiles: ['ember.js'], | |||
| installWithEmberCLI: '# Install the latest Ember canary:\nbower install --save ember#canary' | |||
| installWithEmberCLI: '# Install the latest Ember canary:\nnpm install --save-dev emberjs/ember.js#master' | |||
There was a problem hiding this comment.
This command won't actually work (as it would not have the precompiled dist assets).
There was a problem hiding this comment.
@rwjblue So we cannot install it via npm?
| @@ -13,5 +13,5 @@ export default { | |||
| enableTestURL: true, | |||
| debugFileName: ".debug.js", | |||
| ignoreFiles: ['ember.js'], | |||
| installWithEmberCLI: '# Install Ember %s:\nbower install --save ember#v%s\n# Or, install the latest build of this channel which may include unreleased incremental changes:\nbower install --save ember#release' | |||
| installWithEmberCLI: '# Install Ember %s:\nnpm install --save-dev ember-source@v%s\n# Or, install the latest build of this channel which may include unreleased incremental changes:\nnpm install --save-dev emberjs/ember.js#release' | |||
There was a problem hiding this comment.
Lets remove the channel specific instructions here (they won't work due to lacking prebuild assets).
| @@ -14,5 +14,5 @@ export default { | |||
| enableTestURL: true, | |||
| debugFileName: ".debug.js", | |||
| ignoreFiles: ['ember.js'], | |||
| installWithEmberCLI: '# Install Ember %s:\nbower install --save ember#v%s\n# Or, install the latest build of this channel which may include unreleased incremental changes:\nbower install --save ember#beta' | |||
| installWithEmberCLI: '# Install Ember %s:\nnpm install --save ember-source#v%s\n# Or, install the latest build of this channel which may include unreleased incremental changes:\nnpm install --save emberjs/ember.js#beta' | |||
There was a problem hiding this comment.
Remove "latest build of channel" part
|
Your commit was included in #66, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47