Disable default feature of Inflector #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmoon
approved these changes
Jan 6, 2025
|
Can you rebase this onto the current master to resolve the CI issue? |
nazo6
force-pushed
the
inflector-no-default-feature
branch
from
df86d35 to
6f68edb
Compare
alexmoon
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was looking at the dependency tree, I discovered that the Inflector crate introduces some dependencies like regex on default feature.
It appears that these features are not used by nrf-softdevice-macro, so disabling default-features will reduce the dependencies and improve build times.