Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rand core to 0.9.1 and rand to 0.9.0 #3902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aurelj
Copy link
Contributor

@aurelj aurelj commented Feb 19, 2025

This is kind of a follow-up on #3360.

Note that rand_core now provides a default implementation for TryRngCore so try_fill_bytes() is automatically implemented.

@aurelj
Copy link
Contributor Author

aurelj commented Feb 19, 2025

Note that the failed test is due to ed25519_dalek depending on an old version of rand_core.
See dalek-cryptography/curve25519-dalek#729

@Dirbaio
Copy link
Member

Dirbaio commented Feb 19, 2025

lgtm, but then we need to wait for an ed25519_dalek release

alternatively we could impl both the 0.6 and 0.9 trait, similar to how we do with embedded-hal 0.2 and 1.0

@aurelj
Copy link
Contributor Author

aurelj commented Feb 19, 2025

The rand_core feature of ed25519-dalek is actually only enabled in the dev-dependencies of embassy-boot and only for one test. I just reverted back the rand crate dev-dependencies of embassy-boot to 0.8 for this single test and everything works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants