-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32 SDMMC multiple block read/write support #3843
Open
ost-ing
wants to merge
9
commits into
embassy-rs:main
Choose a base branch
from
ost-ing:sdmmc-multiblocks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you fix CI? |
@ost-ing if you want this merged, CI must be green. To fix the rustfmt job, do If you need help with anything please ask! |
Thanks Dirbaio, been quite busy, will look into it in the next couple of daysOn 23. Feb 2025, at 22:49, Dario Nieuwenhuis ***@***.***> wrote:
@ost-ing if you want this merged, CI must be green.
To fix the rustfmt job, do cargo +nightly fmt.
To fix the build job, look at the output and fix the compiler errors. At the bottom of the job it tells you for which chip it's failing in case you want to reproduce it locally, in this case it's stm32f446re.
If you need help with anything please ask!—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
Dirbaio left a comment (embassy-rs/embassy#3843)
@ost-ing if you want this merged, CI must be green.
To fix the rustfmt job, do cargo +nightly fmt.
To fix the build job, look at the output and fix the compiler errors. At the bottom of the job it tells you for which chip it's failing in case you want to reproduce it locally, in this case it's stm32f446re.
If you need help with anything please ask!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@Dirbaio I've fixed the pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have added multiple block read and write support for the STM32 SDMMC peripheral.
This essentially adds CMD18 (multiple block read), CMD25 (multiple block write) and CMD12 (stop transmission) and sets the transfer up correctly.
I've tested this on SDMMCv2 devices.
I've also updated the
block_device_driver
implementation so it now supports multiple block read/writes. I also believe there is a preexisting issue that theblock_address
does not take into consideration the partition start offset, but I'll wait for confirmation from someone before modifying that.Please let me know what you think as this PR greatly improves the read/write speeds, I would love to see it merged asap.
Kind regards