Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 SDMMC multiple block read/write support #3843

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ost-ing
Copy link

@ost-ing ost-ing commented Feb 4, 2025

Hello, I have added multiple block read and write support for the STM32 SDMMC peripheral.

This essentially adds CMD18 (multiple block read), CMD25 (multiple block write) and CMD12 (stop transmission) and sets the transfer up correctly.

I've tested this on SDMMCv2 devices.

I've also updated the block_device_driver implementation so it now supports multiple block read/writes. I also believe there is a preexisting issue that the block_address does not take into consideration the partition start offset, but I'll wait for confirmation from someone before modifying that.

Please let me know what you think as this PR greatly improves the read/write speeds, I would love to see it merged asap.

Kind regards

@Dirbaio
Copy link
Member

Dirbaio commented Feb 7, 2025

can you fix CI?

@Dirbaio
Copy link
Member

Dirbaio commented Feb 23, 2025

@ost-ing if you want this merged, CI must be green.

To fix the rustfmt job, do cargo +nightly fmt.
To fix the build job, look at the output and fix the compiler errors. At the bottom of the job it tells you for which chip it's failing in case you want to reproduce it locally, in this case it's stm32f446re.

If you need help with anything please ask!

@ost-ing
Copy link
Author

ost-ing commented Feb 23, 2025 via email

@ost-ing
Copy link
Author

ost-ing commented Feb 24, 2025

@Dirbaio I've fixed the pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants