Refactored test to use common method for asserting a hresult

elmahio · Oct 12, 2024 · f5c2c8b · f5c2c8b
1 parent f097386
commit f5c2c8b
Showing 1 changed file with 7 additions and 12 deletions.
diff --git a/test/Elmah.Io.HResults.Test/HResultTest.cs b/test/Elmah.Io.HResults.Test/HResultTest.cs
@@ -14,26 +14,21 @@ public class HResultTest
         public void CanParseKnownFailure(int hresult, string expectedHex, int expectedFacilityCode, string expectedFacilityName, int expectedCode, string expectedName)
         {
             var res = HResult.Parse(hresult);
-            Assert.IsNotNull(res);
-            Assert.That(res.Hex, Is.EqualTo(expectedHex));
-            Assert.That(res.IsFailure, Is.True);
-            Assert.That(res.Facility, Is.Not.Null);
-            Assert.That(res.Facility.Identifier, Is.EqualTo(expectedFacilityCode));
-            Assert.That(res.Facility.Name, Is.EqualTo(expectedFacilityName));
-            Assert.That(res.Facility.IsMatch, Is.True);
-            Assert.That(res.Code, Is.Not.Null);
-            Assert.That(res.Code.Identifier, Is.EqualTo(expectedCode));
-            Assert.That(res.Code.Name, Is.EqualTo(expectedName));
-            Assert.That(res.Code.IsMatch, Is.True);
+            AssertHResult(expectedHex, true, expectedFacilityCode, expectedFacilityName, expectedCode, expectedName, res);
         }
 
         [TestCase(2359297, "0x00240001", 36, "FACILITY_WINDOWSUPDATE", 1, "WU_S_SERVICE_STOP")]
         public void CanParseKnownSuccess(int hresult, string expectedHex, int expectedFacilityCode, string expectedFacilityName, int expectedCode, string expectedName)
         {
             var res = HResult.Parse(hresult);
+            AssertHResult(expectedHex, false, expectedFacilityCode, expectedFacilityName, expectedCode, expectedName, res);
+        }
+
+        private static void AssertHResult(string expectedHex, bool expectedIsFailure, int expectedFacilityCode, string expectedFacilityName, int expectedCode, string expectedName, HResult res)
+        {
             Assert.IsNotNull(res);
             Assert.That(res.Hex, Is.EqualTo(expectedHex));
-            Assert.That(res.IsFailure, Is.False);
+            Assert.That(res.IsFailure, Is.EqualTo(expectedIsFailure));
             Assert.That(res.Facility, Is.Not.Null);
             Assert.That(res.Facility.Identifier, Is.EqualTo(expectedFacilityCode));
             Assert.That(res.Facility.Name, Is.EqualTo(expectedFacilityName));