forked from lightningnetwork/lnd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc1 graph #173
Open
ellemouton
wants to merge
30
commits into
master
Choose a base branch
from
misc1Graph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Misc1 graph #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
ellemouton
force-pushed
the
misc1Graph
branch
from
January 21, 2025 12:39
1587d30
to
fa642a5
Compare
Pull Request Test Coverage Report for Build 12948601523Details
💛 - Coveralls |
ellemouton
force-pushed
the
misc1Graph
branch
5 times, most recently
from
January 22, 2025 12:21
55dfee6
to
5bde390
Compare
The authenticated gossiper is already given access to the graph Builder which has the IsZombieChannel method on it. So this does not need to be passed in as a separate config value.
Simplify the ChannelGraphSource interface by removing this unused method.
For consistency in the graphsessoin.graph interface, we let the FetchNodeFeatures method take a read transaction just like the ForEachNodeDirectedChannel. This is nice because then all calls in the same pathfinding transaction use the same read transaction.
In this commit, we remove the graphsession package which added an uneccessary layer of indirection between the underlying graph and the interface required by the router. After this commit, the graph "session" that the router starts, is now fully encapsulated within the ChannelGraph which means we no longer expose the underlying kvdb.Tx at all. This simplification/encapsulation will also be important for when we implement non-kvdb backends for the graph.
In preparation for an external source (over RPC) or a different DB type implementing this interface, we update the methods to take contexts. In this commit, we add a bunch of context.TODO()s all of which will be removed in the following commits.
Since we want to convert this layer to be purely bbolt CRUD. and we will re-use the name ChannelGraph elsewhere.
When set, LND will not advertise the gossip queries feature bit and it will not initiate gossip syncing with any peer.
We already set `nobootstrap` in the default node flags for itest nodes, so we can remove this check now. This will allow us to later test bootstrapping in an itest.
ellemouton
force-pushed
the
misc1Graph
branch
from
January 24, 2025 11:18
0892009
to
ef1eb55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]
in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.