Shuffle #157
Closed
Shuffle #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is only ever written to and never read from. We remove it so that later on when we want to convert NetAddress into and from a protobuf message, we don't need to encode the ChainHash uneccessarily. This was included in NetAddress when the plan was still to have LND cater for different blockchains.
Simplify the ChannelGraphSource interface by removing this unused method.
For consistency in the graphsessoin.graph interface, we let the FetchNodeFeatures method take a read transaction just like the ForEachNodeDirectedChannel. This is nice because then all calls in the same pathfinding transaction use the same read transaction.
Pull reviewers statsStats of the last 30 days for lnd:
|
So that we can stop depending on kvdb.RTx directly. The implementation of this is currently just a kvdb.RTx but eventually this could be a SQL transaction or even multiple transactions for the case where the query is being sent to both a local and remote db. The only place where we want to expose a transaction right now is for pathfinding, so we only do this for the `graphsession.graph` interface used by pathfinding.
In preparation for a clean graph source interface, we create a new ForEachNode method that does not pass a DB transaction to the call-back provided. The existing method is renamed to ForEachNodeCBTx.
Any call that wants to pass in a transaction to the call-back can make use of ForEachNodeChannelTx instead.
In preparation for adding this method to an interface that can be satisfied by a different DB or even a backing RPC connection, we let it take a context.
In preparation for this interface being backed by an RPC client or different type of DB.
TODO: split up into separate PR...
Define a new GraphSource interface required by the invoicerpc server and remove its access to the graphdb.ChannelGraph pointer.
When set, LND will not advertise the gossip queries feature bit and it will not initiate gossip syncing with any peer.
ellemouton
force-pushed
the
shuffle
branch
4 times, most recently
from
4b6a11d to
9ab9912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.