Grpc graph share #156
Closed
Grpc graph share #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
Pull Request Test Coverage Report for Build 11719458899Details
💛 - Coveralls |
ellemouton
force-pushed
the
grpcGraphShare
branch
from
1ba3f61 to
f417f44
Compare
ellemouton
force-pushed
the
moveGraphDBCode
branch
2 times, most recently
from
a066df1 to
e017ccf
Compare
This struct is only used by tests, so move it to a test file.
So that we can stop depending on kvdb.RTx directly. The implementation of this is currently just a kvdb.RTx but eventually this could be a SQL transaction or even multiple transactions for the case where the query is being sent to both a local and remote db.
Let ForEachNodeChannel always take the new graphdb.RTx.
Let FetchLightningNode take the new abstract graphdb.RTx and use this method everwhere.
In this commit, we defined a new `autopilot.GraphSource` interface which describes what the backing graph source for the autopilot agent needs to implement. Various methods that need the direct graph db pointer are moved to test files since these methods are only used in tests to populate the test graph.
Define a new GraphSource interface required by the invoicerpc server and remove its access to the graphdb.ChannelGraph pointer.
Since this will be used to create any read transaction that can be used with other graph read calls (ie, not limited to path finding).
For any method that takes a call-back which takes a read transaction, it makese sense for the method itself to also take an optional read transaction.
Most call-sites of this method have a read transaction available to pass in. Note that this also means that calls to FetchNodeFeatures made from the router are made under the same read transaction as calls to ForEachNodeDirectedChannel which makes things cleaner.
When set, LND will not advertise the gossip queries feature bit and it will not initiate gossip syncing with any peer.
This is an interface that the LND can provide to other callers systems in the same process.
ellemouton
force-pushed
the
grpcGraphShare
branch
from
f417f44 to
a2cf39d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.