refactor+graph: move all graph related DB code to the graph package #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
Pull Request Test Coverage Report for Build 11578759094Details
💛 - Coveralls |
We'll move these to the new graphdb package later and import them from there.
We also now use the graph DB's own optional functions. An instance of the graph is currently still passed to the channeldb's `CreateWithBackend` function. This will be removed in a later commit once the two have been completely disjoint.
Then use both to construct a multiAddrSource AddrSource and use that around the code-base.
So that this fails earlier on if the actual call to UpdateChannelPolicy fails.
Demonstrate CI passes if we persist graph data in a completely separate DB to other channel data.
ellemouton
force-pushed
the
moveGraphDBCode
branch
from
53b4831 to
54d2eec
Compare
ellemouton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the larger graph separation & gossip updates projects.
This PR is mostly a refactor:
channeldband intograph/db.ChannelGraphfromchanneldb.DB. The only place where the two are used together is forAddrSource, so a couple of commits extract this.TEMP) uses different files/DBs for the graph and channeldb. This is just to demonstrate the clean separation of the two. It is for reviewer confirmation of CI only & will be removed before merge.