Rb update mc #133
Closed
Rb update mc #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
ellemouton
force-pushed
the
rb-updateMC
branch
2 times, most recently
from
f2a90fd to
5483f15
Compare
To prevent the need to copy the entire onion_error.go file for a new Mission Control migration, this commit just updates the existing lnwire21/onion_error.go file with the new CodeInvalidBlinding code. The lnwire21 should not really ever be updated but adding a new code should be fine as it does not affect old migrations since this is a new code.
In preparation for the commit which will add the main logic for migration 32 (which will migrate the MC store to use a more minimal encoding), this commit just adds some of the code that the migration will need to the package.
Add a new mcRoute type that houses the data about a route that MC actually uses. Then add a migration (channeldb/migration32) that migrates the existing store from its current serialisation to the new, more minimal serialisation.
So that `missionControlStore` can be unaware of the backing DB structure it is writing to. In an upcoming commit when we change mission control to write to namespaced buckets instead, we then only need to update the `namespacedDB` implementation.
In this commit, the mission control store is migrated such that all existing pairs which are currently stored directly in the top level results bucket are now instead moved to a "default" namespace bucket. Note that this migration is not yet invoked in this commit. The migration will be invoked in the same commit that starts writing and reading the new format.
and invoke the associated mission control migration.
Only the MissionControl instance should use this variable and it should not be accessible to users of MissionControl.
ellemouton
force-pushed
the
rb-updateMC
branch
from
5483f15 to
103c694
Compare
Pull Request Test Coverage Report for Build 10388847757Details
💛 - Coveralls |
This commit renames the previous MissionControl to MissionController and the previous MissionController interface to MissionControlQuerier. This is done because soon the (new) MissionController will back multiple namespaced MissionControl instances. For now, it just houses a single MissionControl in the default namespace.
TODO: remove replace once dependent PR is merged.
This new struct holds the zpay32.BlindedPaymentPath along with other useful info about the constructed path like: 1) the session key: which we can later use (as the path constructor) to decrypt the blobs we sent to each blinded hop in the path. 2) the last ephemeral pub key which we can use to uniquely identify this path.
Move it to the models package to avoid import cycles later on.
instead of route.Route. This will be useful for a later commit when we only have access to MCRoute and want to report success to MC.
Note that then new field is not yet persisted.
ellemouton
force-pushed
the
rb-updateMC
branch
from
1233e52 to
d5c4c48
Compare
in the new "blinded-paths" namespace.
Start querying blinded path probabilites from the new MC namespace where the results of successful blinded path receives will be written to.
ellemouton
force-pushed
the
rb-updateMC
branch
from
d5c4c48 to
618e74a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: write test