feat: introduce Dependency Injection to enhance developer experience #2115

btspoony · 2025-01-10T14:02:29Z

Relates to

No issue

Risks

Low.

This is a brand new feature.
It is only effective when using dependency injection to load a Class rather than an Object within the plugin.

Background

What does this PR do?

It provides dependency injection-driven object management functions for Eliza's plugin system, enabling Providers, Actions, and Evaluators in the plugin to be initialized in a dynamic way.
It also enables these objects to support multiple existence modes such as Singleton and onRequest, making instance management more flexible.
An abstract class of BaseInjectableAction is created at the same time. Through the @property decorator, the generation of ContentClass and its Template becomes more automated without the need for additional manual creation.

If you want to use this di plugin, your plugin exports will look like:

import { CreateResourceAction } from "./sampleAction";
import { SampleProvider } from "./sampleProvider";
import { SampleEvaluator } from "./sampleEvalutor";
import { PluginOptions } from "../types";

export const samplePlugin: PluginOptions = {
    name: "sample",
    description: "Enables creation and management of generic resources",
    actions: [CreateResourceAction],
    providers: [SampleProvider],
    evaluators: [SampleEvaluator],
    // separate examples will be added for services and clients
    services: [],
    clients: [],
};

export default samplePlugin;

All the actions, providers, evaluators are Class instead of Object.

So the normalization process is added to agent/src/index.ts's startAgents method:

import { normalizeCharacter } from "@elizaos/plugin-di";

const startAgents = async () => {
    // ... 

    if (charactersArg) {
        characters = await loadCharacters(charactersArg);
    }

    // Normalize characters for injectable plugins
    characters = await Promise.all(characters.map(normalizeCharacter));

    // ....
}

This normalizeCharacter method will normalize the plugin with dependency injection Class to the normal plugin.

What kind of change is this?

Features (non-breaking change which adds functionality)

Why are we doing this? Any context or related work?

The Action and Provider in some plugins hope to be initialized in a dynamic way rather than directly exporting an object.
Some Providers may be shared among multiple Plugins. They need to exist in a Singleton instance rather than creating an instance for each plugin.
There are many elements in Action that can be automated through decorator definitions, and this plugin provides a convenient abstract class.

Documentation changes needed?

My changes require a change to the project documentation.

Testing

Where should a reviewer start?

pnpm test --filter=@elizaos/plugin-di

Detailed testing steps

run test cases

Discord username

bt.wood

- Created a new plugin package `@elizaos/plugin-di` to extend the Eliza platform. - Added essential files including `package.json`, `README.md`, and TypeScript configuration. - Implemented core functionalities such as dependency injection using Inversify, action handling, and content evaluation. - Introduced decorators for content properties and Zod schema integration. - Included sample actions and evaluators to demonstrate plugin capabilities. - Configured build and linting scripts for development workflow.

- Introduced a new TypeScript configuration file `tsconfig.build.json` for build-specific settings. - Updated `tsconfig.json` to enable experimental decorators and metadata emission. - Added unit tests for content decorators, validating schema creation and property description loading. - Implemented tests for the `property` decorator to ensure metadata storage functionality.

- Removed export of providers from index.ts. - Added a new file `baseInjectableAction.ts` that defines the `BaseInjactableAction` class, which serves as an abstract base for creating injectable actions. - Introduced action options and methods for processing messages, validating content, and handling actions within the Eliza framework. - Updated `index.ts` in actions directory to export the new base class.

- Fixed a typo in the export statement from `evaluators` to `evalutors` in `index.ts`. - Added a new file `baseInjectableEvalutor.ts` to define the base class for injectable evaluators. - Removed obsolete sample action and evaluator files to streamline the codebase. - Updated `types.ts` to include the `ActionOptions` type definition for better action handling.

- Fixed export typo in `index.ts` from `evalutors` to `evaluators`. - Added `EvaluatorOptions` type definition in `types.ts` for better evaluator configuration. - Introduced new sample action and evaluator files to demonstrate usage within the plugin. - Implemented a base abstract class for injectable evaluators in `baseInjactableEvaluator.ts`. - Updated `createPlugin` function to handle actions more effectively. - Removed obsolete `index.ts` from the `evalutors` directory to clean up the codebase.

…actor structure - Modified the `execute` method in `BaseInjactableAction` and `CreateResourceAction` to accept nullable content. - Introduced a new `CreateResourceContent` class to define the structure of the content for resource creation. - Refactored the `CreateResourceAction` to utilize the new content class and improved validation logic. - Enhanced the callback responses to handle cases where no content is provided, ensuring better error handling.

…and plugin integration - Introduced `CreateResourceAction` to manage resource creation with dependency injection. - Added `SampleEvaluator` for evaluating important content in memory, implementing the `BaseInjactableEvaluator`. - Created `SampleProvider` for data retrieval, adhering to the `InjectableProvider` interface. - Registered new components with the global container for dependency injection. - Defined a `samplePlugin` to encapsulate the new action, evaluator, and provider, facilitating resource management.

- Changed `CreateResourceAction` and `SampleEvaluator` to use `inRequestScope()` for better lifecycle management. - Introduced dynamic data binding in `SampleProvider` with `toDynamicValue()` for asynchronous data retrieval. - Updated `SampleProvider` to inject dynamic data and modified the `get` method to return a string representation of the shared and dynamic data. - Adjusted import statements in `baseInjectableAction.ts` and `baseInjactableEvaluator.ts` to use `import type` for improved type safety.

- Updated the normalizeCharacter function to use optional chaining for plugin properties, enhancing null safety. - Removed unnecessary return statements to streamline the code flow, ensuring that the function consistently returns the plugin object when valid.

- Updated the `createPlugin` function to improve error handling for providers, actions, and evaluators by logging errors and filtering out undefined values. - Implemented optional chaining in the `buildContentOutputTemplate` function to enhance null safety when accessing examples. - Added a new test suite for normalizing characters, ensuring the integrity of plugins and their properties.

- Included "inversify", "reflect-metadata", "zod", and "uuid" as external modules in the tsup configuration to enhance functionality and support for dependency injection and validation.

- Removed the ExtendedPlugin type definition from types.ts to simplify the type structure. - Updated the createPlugin function in plugin.ts to return a Plugin type instead of ExtendedPlugin, reflecting the changes in the type definitions.

wtfsayo · 2025-01-10T21:05:03Z

@coderabbitai review

coderabbitai

Actionable comments posted: 17

🧹 Nitpick comments (20)

packages/plugin-di/src/_examples/samplePlugin.ts (1)
1-3: Consider using path aliases for imports

Replace relative imports with path aliases to improve maintainability and prevent path traversal issues.
-import { CreateResourceAction } from "./sampleAction";
-import { SampleProvider } from "./sampleProvider";
-import { SampleEvaluator } from "./sampleEvalutor";
+import { CreateResourceAction } from "@plugins/sampleAction";
+import { SampleProvider } from "@plugins/sampleProvider";
+import { SampleEvaluator } from "@plugins/sampleEvalutor";
packages/plugin-di/tsup.config.ts (2)
8-8: Fix misleading comment about module format

The comment suggests CommonJS but the configuration specifies ESM.
-    format: ["esm"], // Ensure you're targeting CommonJS
+    format: ["esm"], // Using ES Modules format
3-23: Consider additional build optimizations

The configuration could benefit from additional build options.
 export default defineConfig({
     entry: ["src/index.ts"],
     outDir: "dist",
     sourcemap: true,
     clean: true,
     format: ["esm"],
+    dts: true,  // Generate declaration files
+    minify: true,  // Minify output
+    splitting: true,  // Enable code splitting
     external: [
packages/plugin-di/src/_examples/sampleProvider.ts (1)
27-43: Add lifecycle management for shared instance

The shared instance could lead to memory leaks without proper cleanup.
 private _sharedInstance: Record<string, string>;
+private _disposed = false;
+
+public dispose(): void {
+    this._disposed = true;
+    this._sharedInstance = undefined;
+}

 async getInstance(
     _runtime: IAgentRuntime
 ): Promise<Record<string, string>> {
+    if (this._disposed) {
+        throw new Error('Provider has been disposed');
+    }
     if (!this._sharedInstance) {
         this._sharedInstance = {};
     }
     return this._sharedInstance;
 }
packages/plugin-di/src/evaluators/baseInjactableEvaluator.ts (1)
44-51: Consider strengthening the default validate implementation

The current default implementation always returns true, which might be too permissive. Consider adding basic validation checks or making it abstract.
-    async validate(
+    abstract async validate(
         _runtime: IAgentRuntime,
         _message: Memory,
         _state?: State
-    ): Promise<boolean> {
-        // Default implementation is to return true
-        return true;
-    }
+    ): Promise<boolean>;
packages/plugin-di/src/decorators/content.decorators.ts (1)
31-42: Rename 'constructor' parameter to avoid shadowing

The parameter name 'constructor' shadows the global property. Consider using a more specific name.
-export function createZodSchema<T>(constructor: ContentClass<T>): z.ZodType<T> {
+export function createZodSchema<T>(classConstructor: ContentClass<T>): z.ZodType<T> {
     const properties: Record<string, ContentPropertyConfig> =
-        Reflect.getMetadata(CONTENT_METADATA_KEY, constructor.prototype) || {};
+        Reflect.getMetadata(CONTENT_METADATA_KEY, classConstructor.prototype) || {};

// Similar change in loadPropertyDescriptions
-export function loadPropertyDescriptions<T>(constructor: ContentClass<T>
+export function loadPropertyDescriptions<T>(classConstructor: ContentClass<T>
Also applies to: 50-62

🧰 Tools

🪛 Biome (1.9.4)

[error] 31-31: Do not shadow the global "constructor" property.

Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.

(lint/suspicious/noShadowRestrictedNames)
packages/plugin-di/src/tests/content.decorators.test.ts (2)
26-40: Add more edge cases to schema validation tests

The current tests could be more comprehensive. Consider adding:

Empty object test

Null/undefined property tests

Extra property tests
it("should handle edge cases", () => {
  const schema = createZodSchema(TestClass);
  expect(schema.safeParse({}).success).toBe(false);
  expect(schema.safeParse({ testProperty: null }).success).toBe(false);
  expect(schema.safeParse({ 
    testProperty: "valid",
    extraProp: "invalid"
  }).success).toBe(true); // or false, depending on your requirements
});
58-64: Enhance property decorator tests

The current test only verifies initial undefined state. Consider testing:

Property assignment

Type validation at runtime

Metadata persistence
packages/plugin-di/src/templates.ts (1)
15-26: Consider using array join for better performance.

Instead of string concatenation in a loop, consider using array push and join for better performance with large property sets.
-    let propDesc = "";
-    Object.entries(properties).forEach(([key, { description, examples }]) => {
-        propDesc += `- Field **"${key}"**: ${description}.`;
-        if (examples?.length > 0) {
-            propDesc += " Examples or Rules for this field:\n";
-        } else {
-            propDesc += "\n";
-        }
-        examples?.forEach((example, index) => {
-            propDesc += `    ${index + 1}. ${example}\n`;
-        });
-    });
+    const propDescLines = [];
+    Object.entries(properties).forEach(([key, { description, examples }]) => {
+        propDescLines.push(`- Field **"${key}"**: ${description}.`);
+        if (examples?.length > 0) {
+            propDescLines.push(" Examples or Rules for this field:");
+            examples.forEach((example, index) => {
+                propDescLines.push(`    ${index + 1}. ${example}`);
+            });
+        }
+    });
+    const propDesc = propDescLines.join("\n");
packages/plugin-di/src/types.ts (2)
37-44: Consider adding readonly modifiers.

For immutable properties in ActionOptions, consider adding readonly modifiers to prevent accidental modifications.
 export type ActionOptions<T> = Pick<
     Action,
     "name" | "similes" | "description" | "examples" | "suppressInitialMessage"
 > & {
-    contentClass: ContentClass<T>;
-    template?: string;
-    contentSchema?: z.ZodSchema<T>;
+    readonly contentClass: ContentClass<T>;
+    readonly template?: string;
+    readonly contentSchema?: z.ZodSchema<T>;
 };
115-118: Add index signature for dynamic properties.

Consider adding an index signature to ContentPropertyDescription to allow for additional metadata properties.
 export interface ContentPropertyDescription {
     description: string;
     examples?: string[];
+    [key: string]: unknown;
 }
packages/plugin-di/src/_examples/sampleAction.ts (2)
122-133: Remove commented code.

Either implement the memory persistence logic or remove the commented code. Consider creating a TODO issue if this is planned for future implementation.

101-107: Improve validation logic.

Consider:

Making the API_KEY configurable

Adding validation for required fields
 async validate(
     runtime: IAgentRuntime,
-    _message: Memory,
-    _state?: State
+    message: Memory,
+    state?: State
 ): Promise<boolean> {
-    return !!runtime.character.settings.secrets?.API_KEY;
+    const apiKey = runtime.character.settings.secrets?.API_KEY;
+    if (!apiKey) {
+        elizaLogger.warn("Missing API_KEY in settings");
+        return false;
+    }
+    return true;
 }
packages/plugin-di/src/factories/plugin.ts (1)

25-32: Enhance error handling with error context.

The error handling could be improved by:

Including more context in error messages

Considering retry mechanisms for transient failures

Adding error types/codes for better error handling upstream

Also applies to: 49-57, 75-82
packages/plugin-di/README.md (6)
11-11: Consider using absolute GitHub URLs for examples.

Replace the relative path with an absolute GitHub URL to ensure the link remains valid regardless of where the documentation is viewed.
-Check the [example](./src/_examples/) folder for a simple example of how to create a plugin using Dependency Injection.
+Check the [example](https://github.com/organization/repo/tree/main/packages/plugin-di/src/_examples/) folder for a simple example of how to create a plugin using Dependency Injection.
66-68: Fix grammar in the DI plugin introduction.
-DI plugin provides abstract classes that you can extend to create Injectable actions or evaluators.
+The DI plugin provides abstract classes that you can extend to create Injectable actions or evaluators.
🧰 Tools

🪛 LanguageTool

[uncategorized] ~66-~66: You might be missing the article “the” here.
Context: ...dency ) {} } ``` ### From di plugin DI plugin provides abstract classes that y...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

74-75: Improve property decorator description readability.

Break down the long description into multiple sentences for better clarity.
-This decorator is used to define a property in an action content class  which will be used to generate the action content object Schema and content description template for LLM object generation.
+This decorator defines properties in action content classes. These properties are used to:
+1. Generate the action content object Schema
+2. Create content description templates for LLM object generation
89-89: Fix typo in heading.
-## Abstract Classes for Injaectable Actions and Evaluators
+## Abstract Classes for Injectable Actions and Evaluators
95-96: Fix verb agreement and improve clarity.
-This abstract class simplify the creation of injectable actions.
-You don't need to think about the template for content generation, it will be generated automatically based on the properties of the content Class.
+This abstract class simplifies the creation of injectable actions.
+Templates for content generation are automatically generated based on the properties of the content Class.
🧰 Tools

🪛 LanguageTool

[uncategorized] ~95-~95: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...eInjactableAction` This abstract class simplify the creation of injectable actions. You...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

139-139: Add a conclusion section.

The documentation ends abruptly with a reference. Consider adding:

A conclusion section summarizing key points

A troubleshooting guide

Links to additional resources

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87d8eca and 28ae2d7.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (29)

agent/package.json (1 hunks)
agent/src/index.ts (2 hunks)
packages/plugin-di/.npmignore (1 hunks)
packages/plugin-di/README.md (1 hunks)
packages/plugin-di/eslint.config.mjs (1 hunks)
packages/plugin-di/package.json (1 hunks)
packages/plugin-di/src/_examples/sampleAction.ts (1 hunks)
packages/plugin-di/src/_examples/sampleEvalutor.ts (1 hunks)
packages/plugin-di/src/_examples/samplePlugin.ts (1 hunks)
packages/plugin-di/src/_examples/sampleProvider.ts (1 hunks)
packages/plugin-di/src/actions/baseInjectableAction.ts (1 hunks)
packages/plugin-di/src/actions/index.ts (1 hunks)
packages/plugin-di/src/decorators/content.decorators.ts (1 hunks)
packages/plugin-di/src/decorators/index.ts (1 hunks)
packages/plugin-di/src/di.ts (1 hunks)
packages/plugin-di/src/evaluators/baseInjactableEvaluator.ts (1 hunks)
packages/plugin-di/src/evaluators/index.ts (1 hunks)
packages/plugin-di/src/factories/charactor.ts (1 hunks)
packages/plugin-di/src/factories/index.ts (1 hunks)
packages/plugin-di/src/factories/plugin.ts (1 hunks)
packages/plugin-di/src/index.ts (1 hunks)
packages/plugin-di/src/symbols.ts (1 hunks)
packages/plugin-di/src/templates.ts (1 hunks)
packages/plugin-di/src/tests/content.decorators.test.ts (1 hunks)
packages/plugin-di/src/tests/normalizeCharacter.test.ts (1 hunks)
packages/plugin-di/src/types.ts (1 hunks)
packages/plugin-di/tsconfig.build.json (1 hunks)
packages/plugin-di/tsconfig.json (1 hunks)
packages/plugin-di/tsup.config.ts (1 hunks)

✅ Files skipped from review due to trivial changes (9)

packages/plugin-di/src/actions/index.ts
packages/plugin-di/src/decorators/index.ts
packages/plugin-di/tsconfig.build.json
packages/plugin-di/src/evaluators/index.ts
packages/plugin-di/.npmignore
packages/plugin-di/eslint.config.mjs
packages/plugin-di/tsconfig.json
packages/plugin-di/src/factories/index.ts
packages/plugin-di/src/index.ts

🧰 Additional context used

🪛 LanguageTool

packages/plugin-di/README.md

[uncategorized] ~66-~66: You might be missing the article “the” here.
Context: ...dency ) {} } ``` ### From di plugin DI plugin provides abstract classes that y...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

[uncategorized] ~95-~95: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...eInjactableAction` This abstract class simplify the creation of injectable actions. You...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

🪛 Biome (1.9.4)

packages/plugin-di/src/_examples/sampleEvalutor.ts

[error] 46-46: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

packages/plugin-di/src/decorators/content.decorators.ts

[error] 31-31: Do not shadow the global "constructor" property.

Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.

(lint/suspicious/noShadowRestrictedNames)

[error] 51-51: Do not shadow the global "constructor" property.

Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.

(lint/suspicious/noShadowRestrictedNames)

🔇 Additional comments (5)

packages/plugin-di/src/symbols.ts (1)

4-6: 'FACTORIES' object definition looks good

The FACTORIES object is correctly defined with the PluginFactory symbol.

packages/plugin-di/src/di.ts (1)

7-15: Dependency injection container is properly set up

The DI container is correctly configured with the plugin factory binding.
agent/src/index.ts (1)

929-931: Verify character normalization impact.

The normalization step is crucial for injectable plugins. Ensure that:

All existing plugins remain compatible after normalization

Character configurations are preserved

✅ Verification successful

Character normalization process verified as safe

The normalization step properly preserves plugin compatibility and character configurations. No issues found in the implementation.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Check for potential plugin compatibility issues after normalization

# Test: Search for plugin initialization patterns
rg -A 5 'plugin\.(providers|actions|evaluators)'

# Test: Search for character configuration usage
rg -A 3 'character\.(settings|plugins|clients)'
Length of output: 28797
agent/package.json (1)

43-43: LGTM!

The workspace dependency is correctly added.

packages/plugin-di/README.md (1)

1-139: Well-structured documentation with clear examples!

The documentation effectively introduces DI concepts and provides practical examples. The minor issues noted above don't impact the overall quality and usefulness of the content.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~66-~66: You might be missing the article “the” here.
Context: ...dency ) {} } ``` ### From di plugin DI plugin provides abstract classes that y...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

[uncategorized] ~95-~95: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...eInjactableAction` This abstract class simplify the creation of injectable actions. You...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

packages/plugin-di/src/actions/baseInjectableAction.ts

packages/plugin-di/src/_examples/samplePlugin.ts

packages/plugin-di/src/templates.ts

packages/plugin-di/src/tests/normalizeCharacter.test.ts

packages/plugin-di/src/_examples/sampleAction.ts

packages/plugin-di/src/factories/plugin.ts

packages/plugin-di/package.json

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

btspoony · 2025-01-16T16:00:27Z

I will keep this branch updated daily.
If there is anything else I need to do to get this merged, please let me know.
@shakkernerd

…p sampleEvaluator imports - Changed private properties to protected in BaseInjectableAction for better inheritance support. - Cleaned up imports in sampleEvaluator by removing unused State import and standardizing string quotes.

…tableAction to Promise<any | null> - Updated the return type of the callback in the BaseInjectableAction class to allow for more flexible handling of results, returning null instead of void.

wtfsayo · 2025-01-18T13:37:29Z

@coderabbitai security and second order effect analysis please

coderabbitai · 2025-01-18T13:38:29Z

Tip

For best results, initiate chat on the files or code changes.

@wtfsayo Here's the security and second-order effect analysis of the dependency injection implementation:

Security Analysis:

✅ Container Security
- Proper scope isolation between singleton and request-scoped instances
- No container leaks detected
- No unsafe code execution patterns (eval, Function constructor)
⚠️ Type Safety Concerns
- Multiple as any type assertions found throughout the codebase
- Plugin normalization accepts any type input
- Recommend adding runtime type validation using Zod schemas
✅ Dependency Security
- All dependencies are on stable versions
- Core dependencies (inversify, zod) are well-maintained
- No known vulnerabilities in pinned versions

Second-Order Effects:

🔄 Runtime Behavior
- All characters now undergo normalization process
- Plugins are instantiated per request (isolated state)
- Potential performance impact from additional normalization step
🧠 Memory Management
- Request-scoped instances prevent state leakage
- Singleton scope used appropriately for shared resources
- No detected memory leak patterns

Recommendations:

Enhance type safety:
- Reduce as any usage
- Add Zod schemas for plugin validation
Add monitoring for:
- Plugin normalization performance
- Memory usage patterns in singleton instances
Consider adding a plugin validation phase before normalization

Would you like me to open a GitHub issue for tracking these recommendations?

🔗 Analysis chain

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for potential security issues in dependency injection
echo "Checking for eval usage..."
rg "eval\(" --type ts
echo -e "\nChecking for Function constructor usage..."
rg "new Function" --type ts
echo -e "\nChecking for dynamic imports..."
rg "import\(.*\)" --type ts
echo -e "\nChecking for prototype pollution vectors..."
rg "Object\.prototype" --type ts
rg "Object\.assign" --type ts
echo -e "\nChecking package.json for dependency versions..."
cat packages/plugin-di/package.json | jq '.dependencies, .devDependencies'
echo -e "\nChecking for potential memory leaks in singleton patterns..."
ast-grep --pattern 'class $_ {
  $$$
  private static $_: any;
  $$$
}'
echo -e "\nChecking for unsafe type assertions..."
rg "as any" --type ts

Length of output: 15461

Script:

#!/bin/bash
# Check plugin normalization and DI container setup
echo "Analyzing plugin normalization..."
ast-grep --pattern 'async function normalizePlugin($_, $_) {
  $$$
}'

echo -e "\nAnalyzing DI container configuration..."
ast-grep --pattern 'container.bind($_).to($_)'

echo -e "\nChecking for container scope definitions..."
rg "inSingletonScope|inRequestScope|inTransientScope" --type ts

echo -e "\nChecking for potential container leaks..."
rg "container\.get|container\.resolve" --type ts

Length of output: 1062

Script:

#!/bin/bash
# Check plugin normalization implementation
echo "Analyzing plugin normalization implementation..."
rg -A 10 "async function normalizePlugin" --type ts

echo -e "\nChecking for plugin validation..."
rg -A 5 "function isValidPlugin" --type ts

echo -e "\nAnalyzing character normalization..."
rg -A 10 "async function normalizeCharacter" --type ts

Length of output: 1340

…o develop * 'develop' of https://github.com/mgunnin/virtualDegen: (41 commits) Update README.md (elizaOS#2495) Update README_CN.md (elizaOS#2489) Update README_JA.md (elizaOS#2490) feat: introduce Dependency Injection to enhance developer experience (elizaOS#2115) chore: corrected the link to the banner (elizaOS#2491) chore: update createToken.ts (elizaOS#2493) feat: Solana plugin improvement for flawless transfers (elizaOS#2340) Update README_DE.md (elizaOS#2483) feat: Sui supports the secp256k1/secp256r1 algorithms (elizaOS#2476) chore: remove eslint, prettier, tslint and replace with biome (elizaOS#2439) chore: let -> const fix: lint command fix: unused import and type errors chore: console -> elizaLogger fix: error logging and remove unused import fix: remove unused error var chore: pnpm lock file add openai var Revert "Revert "refactor: dockerize smoke tests (elizaOS#2420)" (elizaOS#2459)" fix swaps evm plugin (elizaOS#2332) ...

btspoony and others added 21 commits January 10, 2025 12:57

feat: apply di in agent index.ts

057196a

docs: update README.md for Dependency Injection Plugin

a7d67ba

fix: correct typo in comment for character normalization in index.ts

18451af

feat: add external dependencies for plugin-di

0a5fed5

- Included "inversify", "reflect-metadata", "zod", and "uuid" as external modules in the tsup configuration to enhance functionality and support for dependency injection and validation.

Merge branch 'develop' into tbh-add-di

d8d9723

fix: pnpm-lock.yaml

41b9d41

Merge branch 'develop' into tbh-add-di

7f8e89d

Merge branch 'develop' into tbh-add-di

2d7b592

Merge branch 'develop' into tbh-add-di

28f263f

Merge branch 'develop' into tbh-add-di

28ae2d7

elizaOS deleted a comment from coderabbitai bot Jan 10, 2025

wtfsayo enabled auto-merge January 10, 2025 21:06

wtfsayo disabled auto-merge January 10, 2025 21:13

coderabbitai bot reviewed Jan 10, 2025

View reviewed changes

wtfsayo and others added 4 commits January 11, 2025 02:58

Update packages/plugin-di/src/actions/baseInjectableAction.ts

10a530c

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update packages/plugin-di/src/actions/baseInjectableAction.ts

534f0a6

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update packages/plugin-di/src/actions/baseInjectableAction.ts

85ed71c

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Merge branch 'develop' into tbh-add-di

0b58ee1

btspoony added 5 commits January 15, 2025 11:17

Merge branch 'develop' into tbh-add-di

569d940

fix: pnpm-lock

638c894

Merge branch 'develop' into tbh-add-di

20ce0e6

Merge branch 'develop' into tbh-add-di

3d08eab

fix: pnpm-lock.yaml

965c6d0

btspoony and others added 13 commits January 17, 2025 20:29

Merge branch 'develop' into tbh-add-di

2229e55

fix: pnpm-lock.yaml

3b7e8d0

Merge branch 'develop' into tbh-add-di

3d612cf

chore: Update version and README for @elizaos/plugin-di

4220924

Merge branch 'develop' into tbh-add-di

f70d523

Merge branch 'develop' into tbh-add-di

136f852

refactor: change return type of processMessages callback in BaseInjec…

b6b3e4b

…tableAction to Promise<any | null> - Updated the return type of the callback in the BaseInjectableAction class to allow for more flexible handling of results, returning null instead of void.

Merge branch 'develop' into tbh-add-di

507208d

Merge branch 'develop' into tbh-add-di

3ae0b1d

chore: update pkg

3015e58

Merge branch 'develop' into tbh-add-di

f859be7

Merge branch 'develop' into tbh-add-di

16a29fc

wtfsayo enabled auto-merge (squash) January 18, 2025 13:41

wtfsayo self-requested a review January 18, 2025 13:47

wtfsayo approved these changes Jan 18, 2025

View reviewed changes

wtfsayo merged commit 9c1e4f5 into elizaOS:develop Jan 18, 2025
6 of 7 checks passed

btspoony deleted the tbh-add-di branch January 18, 2025 14:13

btspoony mentioned this pull request Jan 27, 2025

feat(plugin-di): add Dependency Injection support for services and clients, and di plugin samples to _examples as new folder #2855

Merged

odilitime mentioned this pull request Feb 1, 2025

chore: dev => main 0.1.9 #2361

Merged

btspoony mentioned this pull request Feb 7, 2025

Maintainer request for plugin-di and plugin-flow elizaos-plugins/registry#16

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: introduce Dependency Injection to enhance developer experience #2115

feat: introduce Dependency Injection to enhance developer experience #2115

btspoony commented Jan 10, 2025 •

edited

Loading

wtfsayo commented Jan 10, 2025

coderabbitai bot left a comment

btspoony commented Jan 16, 2025

wtfsayo commented Jan 18, 2025

coderabbitai bot commented Jan 18, 2025

feat: introduce Dependency Injection to enhance developer experience #2115

feat: introduce Dependency Injection to enhance developer experience #2115

Conversation

btspoony commented Jan 10, 2025 • edited Loading

Relates to

Risks

Background

What does this PR do?

What kind of change is this?

Why are we doing this? Any context or related work?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

Discord username

wtfsayo commented Jan 10, 2025

coderabbitai bot left a comment

Choose a reason for hiding this comment

btspoony commented Jan 16, 2025

wtfsayo commented Jan 18, 2025

coderabbitai bot commented Jan 18, 2025

btspoony commented Jan 10, 2025 •

edited

Loading