Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when using pinned variable in with else block #13667

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Fix bug when using pinned variable in with else block #13667

merged 1 commit into from
Jun 15, 2024

Conversation

sabiwara
Copy link
Contributor

Close #13665

josevalim
josevalim approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please backport!

@sabiwara sabiwara merged commit 1c17f1e into elixir-lang:main Jun 15, 2024
9 checks passed
@sabiwara sabiwara deleted the fix-pinned-with-else branch June 15, 2024 09:49
sabiwara added a commit that referenced this pull request Jun 15, 2024
@sabiwara
Fix bug when using pinned variable in with else block (#13667)
ae5707f
@sabiwara
Copy link
Contributor Author

Backported ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinning does not seem to work in 'else' block of 'with' special form
2 participants
@sabiwara @josevalim