Optimize :term #13625
Merged
Optimize :term #13625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
commented
May 31, 2024
| @@ -783,6 +844,10 @@ defmodule Module.Types.Descr do | |||
| end) | |||
| end) | |||
| end) | |||
| |> case do | |||
| [] -> 0 | |||
There was a problem hiding this comment.
@gldubc you will have to do the same for tuples. We no longer match empty list as empty on intersection/difference. It is either zero or an empty map.
josevalim
force-pushed
the
jv-optimize-term
branch
from
9620a97 to
c16befc
Compare
gldubc
approved these changes
Jun 2, 2024
Comment on lines
+91
to
+99
| defguardp is_optional(map) | ||
| when is_map(map) and | ||
| ((is_map_key(map, :bitmap) and (map.bitmap &&& @bit_optional) != 0) or | ||
| (is_map_key(map, :dynamic) and is_map(map.dynamic) and | ||
| is_map_key(map.dynamic, :bitmap) and | ||
| (map.dynamic.bitmap &&& @bit_optional) != 0)) | ||
|
|
||
| defguardp is_optional_static(map) | ||
| when is_map(map) and is_map_key(map, :bitmap) and (map.bitmap &&& @bit_optional) != 0 |
There was a problem hiding this comment.
Suggested change
| defguardp is_optional(map) | |
| when is_map(map) and | |
| ((is_map_key(map, :bitmap) and (map.bitmap &&& @bit_optional) != 0) or | |
| (is_map_key(map, :dynamic) and is_map(map.dynamic) and | |
| is_map_key(map.dynamic, :bitmap) and | |
| (map.dynamic.bitmap &&& @bit_optional) != 0)) | |
| defguardp is_optional_static(map) | |
| when is_map(map) and is_map_key(map, :bitmap) and (map.bitmap &&& @bit_optional) != 0 | |
| defguardp is_optional_static(map) | |
| when is_map(map) and is_map_key(map, :bitmap) and (map.bitmap &&& @bit_optional) != 0 | |
| defguardp is_optional(map) | |
| when is_optional_static(map) or | |
| (is_map(map) and is_map_key(map, :dynamic) and is_optional_static(map.dynamic)) |
possibly easier to read
There was a problem hiding this comment.
I will check later if the Erlang compiler optimizes the duplicate checks efficiently and merge your proposal. :)
|
💚 💙 💜 💛 ❤️ |
josevalim
added a commit
that referenced
this pull request
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.