Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct mixfile path on error messages when custom MIX_EXS #13288

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Jan 26, 2024

I was playing with MIX_EXS and noticed that error messages coming from mix dep.* tasks where still mentioning mix.exs instead of the custom mixfile.

The problem being that from field in Mix.Dep structs didn't consider custom mixfiles apparently.

Does this change make sense?

@josevalim josevalim merged commit 0e4247c into elixir-lang:main Jan 26, 2024
7 of 8 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@grzuy grzuy deleted the mix-exs branch January 27, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants