Add atom singleton types to descr #13277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The :atom field now contains a representation for all possible
atom types. The representation is a pair `{s, bool}` where `s`
is a set of atoms. If `bool` is `true` it represents the union
of the atoms in `s`. Else, it represents every atom except those
in `s`.
`boolean()` is defined as the singletons true, false.
sabiwara
reviewed
Jan 23, 2024
Co-authored-by: Jean Klingler <[email protected]>
Co-authored-by: Jean Klingler <[email protected]>
|
@gldubc seems you got a bootstrapping error from the CI because the MapSet module can't be compiled. |
josevalim
reviewed
Jan 24, 2024
josevalim
reviewed
Jan 24, 2024
josevalim
reviewed
Jan 24, 2024
|
I think this PR is complete now. :) |
sabiwara
reviewed
Jan 24, 2024
lib/elixir/lib/module/types/descr.ex
Outdated
| @@ -50,6 +51,8 @@ defmodule Module.Types.Descr do | |||
| def reference(), do: %{bitmap: @bit_reference} | |||
| def tuple(), do: %{bitmap: @bit_tuple} | |||
|
|
|||
| def boolean(), do: atom([true, false]) | |||
There was a problem hiding this comment.
We could reuse your @boolset here so all calls to this function could return the same structure instead of generating a new one:
Suggested change
| def boolean(), do: atom([true, false]) | |
| def boolean(), do: {:union, @boolset} |
Here is a quick illustration:
defmodule Foo do
@boolset :sets.new(version: 2)
def bool1, do: {:union, @boolset}
def bool2, do: {:union, :sets.new(version: 2)}
end
iex> Foo.bool1() === Foo.bool2()
true
iex> :erts_debug.same(Foo.bool1(), Foo.bool1())
true
iex> :erts_debug.same(Foo.bool2(), Foo.bool2())
falseThere was a problem hiding this comment.
I see; thanks for the illustration! Pushing that change as well
josevalim
reviewed
Jan 25, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :atom field of the descr now represents all possible atom types.
It is done with a pair
{tag, set}wheresetis a set of atoms.If
tag = :unionthe pair represents the union of the atoms in s.Else, if
tag = :negation, it represents every atom except those in s.boolean() is defined as the union of the singletons true, false
edit: re-wrote description using tagged pairs instead of
{set, bool}