Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIX_NO_COMPILE environment variable #13274

Closed
wants to merge 4 commits into from

Conversation

sabiwara
Copy link
Contributor

Close #13241

Replaces #13266

@@ -81,6 +81,9 @@ defmodule Mix.Compilers.Elixir do

{force?, stale, new_deps_config} =
cond do
System.get_env("MIX_NO_COMPILE") in ["1", "true"] ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably place this inside compile.all. This would be specific to Elixir and other compilers would still run, and i think none should.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will fix!

@sabiwara sabiwara marked this pull request as draft January 30, 2024 23:42
@sabiwara
Copy link
Contributor Author

Could not reproduce the issue with the latest changes on main, i.e. passing --no-compile to ecto.migrate or phx.server works without a need for an env var. Closing for now.

@sabiwara sabiwara closed this Jan 31, 2024
@sabiwara sabiwara deleted the mix-no-compile branch January 31, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Changing absolute path of mix project causes full recompilation
2 participants