-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gunicorn (and fix CI) #258
base: dev
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request upgrades the project to use Python 3.12. Key changes include updating the GitHub Actions workflow, Dockerfile, and setup.py to reflect the new Python version, as well as updating package dependencies in requirements.txt to ensure compatibility with Python 3.12. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lvarin - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the PR description with the motivation for this upgrade and any compatibility testing performed. A jump from Python 3.7 to 3.12 is significant and needs proper documentation.
- Have all dependencies been verified to work with Python 3.12? Please provide test results and any compatibility issues found/resolved.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
To make CI work, I needed to make a lot of changes. I will rebase commits a bit to tidy it up. |
Fix CI: - Upgrade to python v3.10 - Upgrade flake to v7 - Upgrade pylint to v3 - Fix setuptools version - Fix possibly-used-before-assignment error reported by lint - Add docker compose output for logs - Fix foca version - Fix flask-authz version - Fix pip version
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with
#XXXX
for more information.Testing
Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.
Documentation
Please document your changes and test cases in the appropriate places, if applicable.
Style
Make sure your changes adhere to the coding/documentation style used throughout the project.
Closing issues
If your changes fix any issue/s, put
closes #XXXX
in your comment to auto-close it/them.Credit
Add your credentials to the list of contributors once your pull request was merged.
Summary by Sourcery
Upgrade the project to use Python 3.12 by updating the Dockerfile, GitHub Actions workflow, and setup.py. Update the foca dependency to version 0.13.0 in requirements.txt.
Build:
CI: