Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gunicorn (and fix CI) #258

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Upgrade gunicorn (and fix CI) #258

wants to merge 1 commit into from

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Jan 9, 2025

IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.

Details

Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with #XXXX for more information.

Testing

Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.

Documentation

Please document your changes and test cases in the appropriate places, if applicable.

Style

Make sure your changes adhere to the coding/documentation style used throughout the project.

Closing issues

If your changes fix any issue/s, put closes #XXXX in your comment to auto-close it/them.

Credit

Add your credentials to the list of contributors once your pull request was merged.

Summary by Sourcery

Upgrade the project to use Python 3.12 by updating the Dockerfile, GitHub Actions workflow, and setup.py. Update the foca dependency to version 0.13.0 in requirements.txt.

Build:

  • Update the Dockerfile to use a base image with Python 3.12.

CI:

  • Update the GitHub Actions workflow to use Python 3.12 for checks.

Copy link

sourcery-ai bot commented Jan 9, 2025

Reviewer's Guide by Sourcery

This pull request upgrades the project to use Python 3.12. Key changes include updating the GitHub Actions workflow, Dockerfile, and setup.py to reflect the new Python version, as well as updating package dependencies in requirements.txt to ensure compatibility with Python 3.12.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated GitHub Actions workflow to use Python 3.12
  • Changed Python version from 3.7 to 3.12 in the setup-python action
.github/workflows/checks.yml
Updated Dockerfile to use a base image with Python 3.12
  • Changed base image from elixircloud/foca:20221110-py3.7 to elixircloud/foca:20240711-py3.12
Dockerfile
Updated Python package dependencies to be compatible with Python 3.12
  • Updated foca package version from 0.12.0 to 0.13.0
requirements.txt
Updated setup.py to reflect support for Python 3.12
  • Changed programming language classifier from Python 3.7 to Python 3.12
setup.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lvarin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please fill out the PR description with the motivation for this upgrade and any compatibility testing performed. A jump from Python 3.7 to 3.12 is significant and needs proper documentation.
  • Have all dependencies been verified to work with Python 3.12? Please provide test results and any compatibility issues found/resolved.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lvarin lvarin changed the title WIP Upgrade to python v3.12 Upgrade gunicorn (and fix CI) Jan 10, 2025
@lvarin
Copy link
Contributor Author

lvarin commented Jan 10, 2025

To make CI work, I needed to make a lot of changes. I will rebase commits a bit to tidy it up.

Fix CI:
  - Upgrade to python v3.10
  - Upgrade flake to v7
  - Upgrade pylint to v3
  - Fix setuptools version
  - Fix possibly-used-before-assignment error reported by lint
  - Add docker compose output for logs
  - Fix foca version
  - Fix flask-authz version
  - Fix pip version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant