Patch utils:::.getHelpFile on the fly #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to copy the contents of .getHelpFile or assignInNamespace into the package.
See eliocamp#27 for context. Unlike the proposed fix, this one avoids breaking translations for people relying on the locale settings.
|
This is great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performs what
trace()does, but manually, because we need bothon.exit()andreturn()to work.Pros:
.getHelpFileorassignInNamespaceinto the package (which are © R Core Team & GPL ≥ 2)Cons:
R CMD checkstill complains aboutunlockBindingand:::Hopefully none of this will be needed when translation modules become part of base R.
Edit: the second commit fixes the remaining problem noted by #27. Please let me know if you are interested in a different solution.