fix: handle missing FFmpegAudio._process in cleanup (DisnakeDev#1164)

elenakrittik · Mar 19, 2024 · d92ba6a · d92ba6a
1 parent 227ec80
commit d92ba6a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/1164.bugfix.rst b/changelog/1164.bugfix.rst
@@ -0,0 +1 @@
+Avoid ``AttributeError`` in :class:`FFmpegAudio` when cleaning up after failing to spawn ffmpeg process.
diff --git a/disnake/player.py b/disnake/player.py
@@ -175,7 +175,12 @@ def _spawn_process(self, args: Any, **subprocess_kwargs: Any) -> subprocess.Pope
             raise ClientException(f"Popen failed: {exc.__class__.__name__}: {exc}") from exc
 
     def _kill_process(self) -> None:
-        proc = self._process
+        try:
+            proc = self._process
+        except AttributeError:
+            # may occur if something errors while spawning process
+            return
+
         if proc is MISSING:
             return
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Avoid ``AttributeError`` in :class:`FFmpegAudio` when cleaning up after failing to spawn ffmpeg process.