Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jpeg pipeline #212

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Conversation

OlivierDuchateau
Copy link
Contributor

@OlivierDuchateau OlivierDuchateau commented Dec 19, 2021

Fixes #193

@jeremypw
Copy link
Collaborator

This PR seems to work OK, but I cannot reproduce the original issue on my system any using the master source. So its best that PR be reviewed by someone experiencing the issue with their camera.

@canopusStar
Copy link

This PR seems to work OK, but I cannot reproduce the original issue on my system any using the master source. So its best that PR be reviewed by someone experiencing the issue with their camera.

Do you require me to do something to assist further.
Having issues with jargon (unsure of the actual implications of anything on this page...)

@jeremypw
Copy link
Collaborator

jeremypw commented Dec 20, 2021

@canopusStar Do you have any experience in building Flatpaks from source code? If not there is not much you can do I am afraid. If you are interested in learning there is some information on how to build elementary apps at https://docs.elementary.io/develop/

I do not experience the issue this is supposed to fix and do not have enough expertise in GStreamer to judge the change other that testing it. All I can say is that it does not seem to break anything.

@danirabbit
Copy link
Member

We build Flatpak bundles in CI, so @canopusStar can download and install this bundle with sideload to test: https://github.com/elementary/camera/suites/4705052344/artifacts/128930760

@jeremypw
Copy link
Collaborator

Thanks @danrabbit - I didnt know that.

@canopusStar
Copy link

We build Flatpak bundles in CI, so @canopusStar can download and install this bundle with sideload to test: https://github.com/elementary/camera/suites/4705052344/artifacts/128930760

This has fixed both the image and the video issue variously described as 'zero byte files created by the camera app'.

Thanks danrabbit & jeremypw

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As no regressions were found and an affected user found this fixed the issue I am happy to approve this.

@danirabbit
Copy link
Member

I also want to request a review from @cassidyjames just in case here because I know he's been working with @tintou on some camera stuff for StarBook

Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't change anything for me on StarBook, so I'm happy to merge.

@cassidyjames cassidyjames enabled auto-merge (squash) December 21, 2021 19:55
@cassidyjames cassidyjames merged commit bb4c9e1 into elementary:master Dec 21, 2021
@danirabbit
Copy link
Member

Thanks for the fix @OlivierDuchateau !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera files are zero byte files associated with code application. Video and stills affected.
5 participants