-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jpeg pipeline #212
Fix jpeg pipeline #212
Conversation
This PR seems to work OK, but I cannot reproduce the original issue on my system any using the master source. So its best that PR be reviewed by someone experiencing the issue with their camera. |
Do you require me to do something to assist further. |
@canopusStar Do you have any experience in building Flatpaks from source code? If not there is not much you can do I am afraid. If you are interested in learning there is some information on how to build elementary apps at https://docs.elementary.io/develop/ I do not experience the issue this is supposed to fix and do not have enough expertise in GStreamer to judge the change other that testing it. All I can say is that it does not seem to break anything. |
We build Flatpak bundles in CI, so @canopusStar can download and install this bundle with sideload to test: https://github.com/elementary/camera/suites/4705052344/artifacts/128930760 |
Thanks @danrabbit - I didnt know that. |
This has fixed both the image and the video issue variously described as 'zero byte files created by the camera app'. Thanks danrabbit & jeremypw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As no regressions were found and an affected user found this fixed the issue I am happy to approve this.
I also want to request a review from @cassidyjames just in case here because I know he's been working with @tintou on some camera stuff for StarBook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't change anything for me on StarBook, so I'm happy to merge.
Thanks for the fix @OlivierDuchateau ! |
Fixes #193