Skip to content

Commit

Permalink
Ele 4006 support test description (#778)
Browse files Browse the repository at this point in the history
* add support for test description from 1.9

* remove default from meta
  • Loading branch information
NoyaArie authored Jan 30, 2025
1 parent dd84c68 commit d13b0fe
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions macros/edr/dbt_artifacts/upload_dbt_tests.sql
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,18 @@
{% set default_description = elementary.get_default_description(test_original_name, test_namespace) %}

{% set config_meta_dict = elementary.safe_get_with_default(config_dict, 'meta', {}) %}
{% set meta_dict = {} %}
{% if default_description %}
{% set meta_dict = {'description': default_description} %}
{% endif %}
{% do meta_dict.update(elementary.safe_get_with_default(node_dict, 'meta', {})) %}
{% set meta_dict = elementary.safe_get_with_default(node_dict, 'meta', {}) %}
{% do meta_dict.update(config_meta_dict) %}

{% set description = none %}
{% if dbt_version >= '1.9.0' and node_dict.get('description') %}
{% set description = node_dict.get('description') %}
{% elif meta_dict.get('description') %}
{% set description = meta_dict.pop('description') %}
{% elif default_description %}
{% set description = default_description %}
{% endif %}

{% set config_tags = elementary.safe_get_with_default(config_dict, 'tags', []) %}
{% set global_tags = elementary.safe_get_with_default(node_dict, 'tags', []) %}
{% set meta_tags = elementary.safe_get_with_default(meta_dict, 'tags', []) %}
Expand Down Expand Up @@ -160,7 +165,7 @@
'depends_on_macros': elementary.filter_none_and_sort(depends_on_dict.get('macros', [])),
'depends_on_nodes': elementary.filter_none_and_sort(depends_on_dict.get('nodes', [])),
'parent_model_unique_id': primary_test_model_id.data,
'description': meta_dict.get('description'),
'description': description,
'name': node_dict.get('name'),
'package_name': node_dict.get('package_name'),
'type': elementary.get_test_sub_type(original_file_path, test_namespace),
Expand Down

0 comments on commit d13b0fe

Please sign in to comment.