Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compatibility sessions that do not have devices #3801

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

reivilibre
Copy link
Contributor

This is needed for full support of existing Synapse access tokens

Closes #2149 by supporting deviceless tokens instead

Not sure if all the design choices here are right:

  • we don't sync deviceless sessions with Synapse
  • we don't add a device scope token for deviceless sessions

This is needed for full support of existing Synapse access tokens
@reivilibre reivilibre requested a review from sandhose January 15, 2025 18:33
Copy link

cloudflare-workers-and-pages bot commented Jan 15, 2025

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8a28545
Status: ✅  Deploy successful!
Preview URL: https://61e8b885.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://rei-supp-deviceless-ats.matrix-authentication-service-docs.pages.dev

View logs

crates/storage-pg/src/compat/session.rs Outdated Show resolved Hide resolved
crates/tasks/src/matrix.rs Outdated Show resolved Hide resolved
@reivilibre reivilibre requested a review from sandhose January 24, 2025 15:46
@reivilibre reivilibre merged commit 0c26dd8 into main Jan 27, 2025
21 checks passed
@reivilibre reivilibre deleted the rei/supp_deviceless_ats branch January 27, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration advisor does not warn about device-less tokens
2 participants