Warn and block sending on verification violation #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3679 +/- ##
===========================================
- Coverage 78.50% 78.48% -0.03%
===========================================
Files 792 792
Lines 67338 67596 +258
===========================================
+ Hits 52864 53050 +186
- Misses 14474 14546 +72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BillCarsonFr
force-pushed
the
valere/identity_violation_banner
branch
from
1cc742b to
47671c0
Compare
BillCarsonFr
changed the title
BillCarsonFr
force-pushed
the
valere/identity_violation_banner
branch
from
e3422f9 to
f7003cb
Compare
BillCarsonFr
force-pushed
the
valere/identity_violation_banner
branch
from
6b00504 to
0feecfa
Compare
stefanceriu
requested review from
stefanceriu
and removed request for
Velin92
stefanceriu
approved these changes
Jan 20, 2025
|
andybalaam
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Part of element-hq/element-meta#2492 (still partial as there is no way to verify other users yet on EX, so you can only withdraw the verification requirement).
EXI counterpart of EXA element-hq/element-x-android#4126
Adds support for identity violation detection. Will show a warning notice and block sending (notice that sending would fail anyhow in that case).
