Improve rendering of empty topics in the timeline #29152
+62
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Jan 31, 2025
src/i18n/strings/cs.json
Outdated
There was a problem hiding this comment.
These changes will be discarded as Localazy is the source of truth for non-source languages. You would likely want to update the key in Localazy first, then enact this change combined with a Localazy download.
There was a problem hiding this comment.
Should I make the change once this PR is approved, so that there isn't a chance for the key to change before this has merged?
Half-Shot
commented
Jan 31, 2025
| @@ -145,6 +145,8 @@ export default class RoomProfileSettings extends React.Component<IProps, IState> | |||
|
|
|||
| if (this.state.originalTopic !== this.state.topic) { | |||
| const html = htmlSerializeFromMdIfNeeded(this.state.topic, { forceHTML: false }); | |||
| // XXX: Note that we deliberately send an empty string on an empty topic rather | |||
There was a problem hiding this comment.
I wanted to call this behavior out explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#4673
For element-hq/element-meta#2705
Checklist
public/exportedsymbols have accurate TSDoc documentation.