Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Element Call video rooms #26819

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Force Element Call video rooms #26819

merged 3 commits into from
Jan 24, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jan 3, 2024

Video rooms are currently using jitsi. The VoiP team is planning to sunset jitsi in the longer term.
As the first step the video rooms (which are a beta feature that needs to be activated) are using EC instead of jitsi.

This PR activates feature_element_call_video_rooms on develop.element.io so that video rooms default to element call instead of jitis.

(existing jitsi video rooms will stay configured with jitsi.)

The PR for Element Desktop: element-hq/element-desktop#1413


This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Timo K <[email protected]>
@toger5 toger5 requested a review from a team as a code owner January 3, 2024 16:09
@toger5 toger5 requested review from andybalaam and t3chguy January 3, 2024 16:09
@toger5 toger5 added the T-Task Tasks for the team like planning label Jan 3, 2024
@t3chguy t3chguy requested a review from a team January 3, 2024 16:29
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be applied to Nightly also?

@toger5 toger5 changed the title Force EC video rooms Force Element Call video rooms Jan 3, 2024
@toger5
Copy link
Contributor Author

toger5 commented Jan 3, 2024

Created: element-hq/element-desktop#1413

@fkwp
Copy link
Contributor

fkwp commented Jan 5, 2024

product approved

Copy link

@Aziz-4980 Aziz-4980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toger5 toger5 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into develop with commit 8af9fe2 Jan 24, 2024
21 checks passed
@toger5 toger5 deleted the toger5/force_ec_video_rooms branch January 24, 2024 13:23
@toger5
Copy link
Contributor Author

toger5 commented Jan 24, 2024

The companion PR: element-hq/element-desktop#1413 for element deskop is not yet approved.
Would be great to merge this soonish so the both are behaving similarly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants