Add Nordeck's Synapse Guest Module #3
Conversation
…ebe7 git-subtree-dir: modules/restricted-guests/synapse git-subtree-split: 0cfebe7ba5a7368d31bf1f290bd72ff7aed513eb
…estricted-guests/synapse'
This fixes a false-positive "missing file" check in knip
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,18 @@ | |||
| # Copyright 2023 Nordeck IT + Consulting GmbH | |||
| # Copyright 2025 New Vector Ltd. | |||
There was a problem hiding this comment.
Does this not need dual-licensing for the Element Commercial License? https://github.com/element-hq/element-modules/tree/main/packages/element-web-module-api#copyright--license
There was a problem hiding this comment.
Good point, I believe it does
Checkout from @nordeck/[email protected]
Also remove jobs for E2E & changeset, which aren't set up in this repo
|
Note that upstream doesn't have SonarCloud codecov checks, so naturally the coverage on the Synapse module will fail. Should we add something for this, or would it make more sense to do what Synapse does and use |
There was a problem hiding this comment.
Should we add something for this, or would it make more sense to do what Synapse does and use coverage?
Given tests are here, it'd be great to wire them up to Sonar coverage. I don't think we need to hit any specific bar but it'd be good to have insight as to what level of coverage exists
The work done by the script is simpler to achieve in Bash, and avoids a potential mis-parsing of arguments.
Imports https://github.com/nordeck/element-web-modules/tree/main/packages/synapse-guest-module
The initial import was done with
git subtree: