Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wave/hello reaction #2921

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Add wave/hello reaction #2921

merged 3 commits into from
Jan 8, 2025

Conversation

davidegirardi
Copy link
Contributor

Add a way to semi-quietly say hello when joining a meeting.

@davidegirardi davidegirardi requested a review from a team as a code owner December 28, 2024 11:42
@davidegirardi davidegirardi requested a review from toger5 December 28, 2024 11:42
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ davidegirardi
❌ Davide Girardi


Davide Girardi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Half-Shot
Copy link
Member

Failing test is due to expect(container).toMatchSnapshot(); in one of the tests failing due to the extra reaction button. We can probably change/remove that expect without too much trouble.

@hughns hughns added the X-Needs-Design May require input from the design team label Jan 6, 2025
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes total sense to add a wave reaction. I'm not sure about the chosen sound (also where did the sound file come from so that we can confirm it has compatible license?).

I've added the design label to get input on the sound to use.

@davidegirardi
Copy link
Contributor Author

I'm not sure about the chosen sound

I went for something that could sound like an hello without having any words in it. It also sounds quite small by choice, to not be distracting if somebody uses it while someone else is talking (the opposite of the rock reaction so to speak 😬).

@hughns hughns removed the X-Needs-Design May require input from the design team label Jan 8, 2025
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst I'm not sure about the exact sound, I've discussed with @fkwp and we will merge it as is for now. We can change the sound later on if needed.

I'm overruling the CLA bot as I know @davidegirardi works for Element.

@hughns hughns merged commit d5bf650 into livekit Jan 8, 2025
6 of 7 checks passed
@hughns hughns deleted the dg/add-wave-reaction branch January 8, 2025 14:05
@davidegirardi
Copy link
Contributor Author

Happy to hear about any kind of direction we want to take with sound design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants