-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wave/hello reaction #2921
Add wave/hello reaction #2921
Conversation
Davide Girardi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Failing test is due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes total sense to add a wave reaction. I'm not sure about the chosen sound (also where did the sound file come from so that we can confirm it has compatible license?).
I've added the design label to get input on the sound to use.
I went for something that could sound like an hello without having any words in it. It also sounds quite small by choice, to not be distracting if somebody uses it while someone else is talking (the opposite of the rock reaction so to speak 😬). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst I'm not sure about the exact sound, I've discussed with @fkwp and we will merge it as is for now. We can change the sound later on if needed.
I'm overruling the CLA bot as I know @davidegirardi works for Element.
Happy to hear about any kind of direction we want to take with sound design. |
Add a way to semi-quietly say hello when joining a meeting.