build: update CI file to lock actions and pass CI #196
+4,649
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
update
branch
from
df3724a to
731f6d5
Compare
The in-range version of tmp-promise only supports node 14 and higher
|
Now includes CFA for auto-release 👍 |
erickzhao
approved these changes
Jan 8, 2025
| os: [windows-latest, macOS-latest, ubuntu-latest] | ||
| node-version: [10.x, 12.x] | ||
| os: [windows-latest, macos-13, ubuntu-latest] | ||
| node-version: [14.x, 16.x, 18.x, 20.x] |
There was a problem hiding this comment.
Is it overkill to include 22.x as well since that's LTS?
| - name: Install | ||
| run: | | ||
| npm install --engine-strict | ||
| npm update | ||
| yarn install --frozen-lockfile --ignore-engines |
There was a problem hiding this comment.
Is it intentional that we're keeping --ignore-engines here?
There was a problem hiding this comment.
Yeah there's a testing dependency that declares it's node version range wrong. Still works clearly 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a lockfile because lock files are good.
Also turns out that despite the package claiming to support node 10/12, it did not due to the
tmp-promisedependency. So I'm just being realistic and updating the min version to 14 to match reality. Tests are also added / passing now.