chore: migrate from BluebirdPromise to vanilla Promise API
#8810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc-pool` for setting concurrency limit
🦋 Changeset detectedLatest commit: 366b9a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…move-bluebird # Conflicts: # packages/app-builder-lib/src/asar/integrity.ts # packages/app-builder-lib/src/codeSign/macCodeSign.ts # packages/app-builder-lib/src/electron/ElectronFramework.ts # packages/app-builder-lib/src/electron/electronMac.ts # packages/app-builder-lib/src/fileMatcher.ts # packages/app-builder-lib/src/macPackager.ts # packages/app-builder-lib/src/platformPackager.ts # packages/app-builder-lib/src/targets/AppxTarget.ts # packages/app-builder-lib/src/targets/MsiTarget.ts # packages/app-builder-lib/src/util/NodeModuleCopyHelper.ts # packages/app-builder-lib/src/util/appFileCopier.ts # packages/app-builder-lib/src/util/cacheManager.ts # packages/builder-util/src/fs.ts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plenty of reasons to modernize from Bluebird, here's one from the library author petkaantonov/bluebird@c220cfe
For operations that require setting a concurrency limit, such as bulk disk/file operations, we'll leverage
tiny-async-poolfor setting a concurrency limit while still leveraging pure vanillaPromiseice cream.https://github.com/rxaviers/async-pool/blob/1.x/lib/es6.js