Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdx → asciidoc] Add AsciiDoc serverless files #6061

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Nov 4, 2024

Related to elastic/docs#3096

I did a full review where I looked at:

  • The diff between the MDX and AsciiDoc file for each page and confirmed that the only changes were to the syntax.
  • The rendered result of the both the MDX version and AsciiDoc version of each page side-by-side and confirmed that they result in the same structure.

This PR adds AsciiDoc files and images to replace DocIcon. A few MDX files are edited where the MDX syntax was incorrect. MDX files will be deleted in a follow-up PR.

You can see the result in this preview: https://docs_bk_3096.docs-preview.app.elstc.co/guide/en/serverless/current/what-is-security-serverless.html

Copy link

github-actions bot commented Nov 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Nov 4, 2024

This pull request does not have a backport label. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Nov 4, 2024
@elasticdocs
Copy link

elasticdocs commented Nov 4, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@colleenmcginnis colleenmcginnis marked this pull request as ready for review November 5, 2024 16:03
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner November 5, 2024 16:03
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚢 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants