Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synthetics] Update TLS certificate rule doc to include Synthetics #4750

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Jan 7, 2025

Description

Updates the TLS certificate rule doc to include both the Uptime TLS rule and the Synthetics TLS certificate rule, and updates the format to match the Monitor status rule doc.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
    • Note: I'll copy over just the Synthetics section to Serverless after review.
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4745

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@colleenmcginnis colleenmcginnis added backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Jan 7, 2025
@colleenmcginnis colleenmcginnis self-assigned this Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review January 9, 2025 19:41
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner January 9, 2025 19:41
alaudazzi
alaudazzi previously approved these changes Jan 10, 2025
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor editing suggestions, otherwise LGTM.

Co-authored-by: Arianna Laudazzi <[email protected]>
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭 👍 🔥

@colleenmcginnis colleenmcginnis merged commit a18b7e9 into elastic:main Jan 10, 2025
4 checks passed
@colleenmcginnis colleenmcginnis deleted the issue-4745 branch January 10, 2025 16:29
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
…4750)

* update tls rule doc to include synthetics

* apply suggestions from code review

Co-authored-by: Arianna Laudazzi <[email protected]>

---------

Co-authored-by: Arianna Laudazzi <[email protected]>
(cherry picked from commit a18b7e9)
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
…4750)

* update tls rule doc to include synthetics

* apply suggestions from code review

Co-authored-by: Arianna Laudazzi <[email protected]>

---------

Co-authored-by: Arianna Laudazzi <[email protected]>
(cherry picked from commit a18b7e9)
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
…4750)

* update tls rule doc to include synthetics

* apply suggestions from code review

Co-authored-by: Arianna Laudazzi <[email protected]>

---------

Co-authored-by: Arianna Laudazzi <[email protected]>
(cherry picked from commit a18b7e9)
colleenmcginnis added a commit that referenced this pull request Jan 10, 2025
…4750) (#4756)

* update tls rule doc to include synthetics

* apply suggestions from code review

Co-authored-by: Arianna Laudazzi <[email protected]>

---------

Co-authored-by: Arianna Laudazzi <[email protected]>
(cherry picked from commit a18b7e9)

Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Jan 10, 2025
…4750) (#4755)

* update tls rule doc to include synthetics

* apply suggestions from code review

Co-authored-by: Arianna Laudazzi <[email protected]>

---------

Co-authored-by: Arianna Laudazzi <[email protected]>
(cherry picked from commit a18b7e9)

Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Jan 10, 2025
…4750) (#4757)

* update tls rule doc to include synthetics

* apply suggestions from code review

Co-authored-by: Arianna Laudazzi <[email protected]>

---------

Co-authored-by: Arianna Laudazzi <[email protected]>
(cherry picked from commit a18b7e9)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Add Synthetics TLS certificate rule page
3 participants