[Charts] Fix borealis theme overrides #209595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
approved these changes
Feb 4, 2025
nickofthyme
added
backport:prev-minor
|
Starting backport for target branches: 9.0 |
💚 Build Succeeded
Metrics [docs]Page load bundle
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 4, 2025
## Summary This removes an override that was applied to the charts theme prior to updating the `Theme` in `@elastic/charts`. This is no longer needed and is now using the wrong color. ## Release note Fixes issue with `Amsterdam` theme where charts render with the incorrect background color. (cherry picked from commit 5954061)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Charts] Fix borealis theme overrides (#209595)](#209595) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-04T18:54:19Z","message":"[Charts] Fix borealis theme overrides (#209595)\n\n## Summary\r\n\r\nThis removes an override that was applied to the charts theme prior to\r\nupdating the `Theme` in `@elastic/charts`. This is no longer needed and\r\nis now using the wrong color.\r\n\r\n## Release note\r\n\r\nFixes issue with `Amsterdam` theme where charts render with the\r\nincorrect background color.","sha":"595406176fd82b3e0c1ce967d8a801e428e0e94a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","backport:current-major","v9.1.0"],"title":"[Charts] Fix borealis theme overrides","number":209595,"url":"https://github.com/elastic/kibana/pull/209595","mergeCommit":{"message":"[Charts] Fix borealis theme overrides (#209595)\n\n## Summary\r\n\r\nThis removes an override that was applied to the charts theme prior to\r\nupdating the `Theme` in `@elastic/charts`. This is no longer needed and\r\nis now using the wrong color.\r\n\r\n## Release note\r\n\r\nFixes issue with `Amsterdam` theme where charts render with the\r\nincorrect background color.","sha":"595406176fd82b3e0c1ce967d8a801e428e0e94a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209595","number":209595,"mergeCommit":{"message":"[Charts] Fix borealis theme overrides (#209595)\n\n## Summary\r\n\r\nThis removes an override that was applied to the charts theme prior to\r\nupdating the `Theme` in `@elastic/charts`. This is no longer needed and\r\nis now using the wrong color.\r\n\r\n## Release note\r\n\r\nFixes issue with `Amsterdam` theme where charts render with the\r\nincorrect background color.","sha":"595406176fd82b3e0c1ce967d8a801e428e0e94a"}}]}] BACKPORT--> Co-authored-by: Nick Partridge <[email protected]>
|
@markov00 where else should be backport this to? |
|
I don't believe we need to merge it in 8.x because borealis changes are applied only to 9.x branch as recommended here #199715 (comment) The most important thing is to consider every fix on elastic-charts that needs to be in 8.x to be backported to 68.x before being merged into 8.x |
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
## Summary This removes an override that was applied to the charts theme prior to updating the `Theme` in `@elastic/charts`. This is no longer needed and is now using the wrong color. ## Release note Fixes issue with `Amsterdam` theme where charts render with the incorrect background color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes an override that was applied to the charts theme prior to updating the
Themein@elastic/charts. This is no longer needed and is now using the wrong color.Fixes #209596
Zight.Recording.2025-02-04.at.11.14.44.AM.mp4
Checklist
release_note:*label is applied per the guidelinesRelease note
Fixes issue with
Amsterdamtheme where charts render with the incorrect background color.