github-action: Add AsciiDoc freeze warning #208534
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,20 @@ | ||||||||||
| --- | ||||||||||
| name: Comment on PR for .asciidoc changes | ||||||||||
|
|
||||||||||
| on: | ||||||||||
| pull_request: | ||||||||||
| types: | ||||||||||
| - synchronize | ||||||||||
|
There was a problem hiding this comment. This may end up leaving quite a few duplicate comments. I'm assuming it's to catch already open pull requests, but wanted to make a note. |
||||||||||
| - opened | ||||||||||
| - reopened | ||||||||||
| branches: | ||||||||||
| - main | ||||||||||
| - master | ||||||||||
| - "9.0" | ||||||||||
|
Comment on lines
+12
to
+14
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. Will 9.0 be created today? |
||||||||||
|
|
||||||||||
| jobs: | ||||||||||
| comment-on-asciidoc-change: | ||||||||||
| permissions: | ||||||||||
| contents: read | ||||||||||
| pull-requests: write | ||||||||||
| uses: elastic/docs-builder/.github/workflows/comment-on-asciidoc-changes.yml@main | ||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we consider using paths? The checkout is taking ~5 minutes currently
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-your-pull_request-workflow-based-on-files-changed-in-a-pull-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion.
I changed the implementation to use an existing action which does not depend on
fetch-depth: 0.Hence, I think, the checkout time should decrease.