-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Eui visual refresh - make palettes theme aware #205873
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Lucas, thanks so much for updating the configs for map and visualizations:
I think we can keep the changes for map, as for visualizations should have been updated in the PRs below:
#204631 (comment)
#206254
3fce630
to
9825390
Compare
Done, this PR is just about the map config now:) @angorayc |
...curity/plugins/security_solution/public/explore/network/components/embeddables/map_config.ts
Outdated
Show resolved
Hide resolved
...curity/plugins/security_solution/public/explore/network/components/embeddables/map_config.ts
Show resolved
Hide resolved
...curity/plugins/security_solution/public/explore/network/components/embeddables/map_config.ts
Outdated
Show resolved
Hide resolved
...curity/plugins/security_solution/public/explore/network/components/embeddables/map_config.ts
Outdated
Show resolved
Hide resolved
...curity/plugins/security_solution/public/explore/network/components/embeddables/map_config.ts
Outdated
Show resolved
Hide resolved
...curity/plugins/security_solution/public/explore/network/components/embeddables/map_config.ts
Outdated
Show resolved
Hide resolved
...curity/plugins/security_solution/public/explore/network/components/embeddables/map_config.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code changes LGTM from EUI side.
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Summary
This PR resolves #201882 by making sure that EUI palette functions are called during component re-renders in Security Solution.
Testing
Please verify if visualizations are displayed properly.
Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:
Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true
Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start
This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.