[Streams] Make root stream selectively immutable #205609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
release_note:skip
dgieselaar
reviewed
Jan 7, 2025
x-pack/solutions/observability/plugins/streams/server/routes/streams/edit.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/observability/plugins/streams/server/routes/streams/edit.ts
Outdated
Show resolved
Hide resolved
💔 Build Failed
Failed CI StepsTest Failures
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
cc @Kerry350 |
dgieselaar
approved these changes
Jan 7, 2025
simianhacker
approved these changes
Jan 7, 2025
…table-root-stream
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
## Summary This closes elastic/streams-program#54. The root stream is selectively immutable (processing and fields changes are not allowed). ## UI For the UI I've entirely disabled the actions column for the root stream in the schema editor. All of the information (bar the preview table for changes) available in the flyout for a field is already available in the table, so this seems easiest for now to avoid multiple logic forks wrapping buttons etc. E.g. flyout vs table 
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
flash1293
added
backport:version
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 10, 2025
## Summary This closes elastic/streams-program#54. The root stream is selectively immutable (processing and fields changes are not allowed). ## UI For the UI I've entirely disabled the actions column for the root stream in the schema editor. All of the information (bar the preview table for changes) available in the flyout for a field is already available in the table, so this seems easiest for now to avoid multiple logic forks wrapping buttons etc. E.g. flyout vs table  (cherry picked from commit 4ba5879)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2025
…6291) # Backport This will backport the following commits from `main` to `8.x`: - [[Streams] Make root stream selectively immutable (#205609)](#205609) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T12:34:52Z","message":"[Streams] Make root stream selectively immutable (#205609)\n\n## Summary\r\n\r\nThis closes https://github.com/elastic/streams-program/issues/54.\r\n\r\nThe root stream is selectively immutable (processing and fields changes\r\nare not allowed).\r\n\r\n## UI\r\n\r\nFor the UI I've entirely disabled the actions column for the root stream\r\nin the schema editor. All of the information (bar the preview table for\r\nchanges) available in the flyout for a field is already available in the\r\ntable, so this seems easiest for now to avoid multiple logic forks\r\nwrapping buttons etc.\r\n\r\nE.g. flyout vs table\r\n\r\n","sha":"4ba5879fa932945004f0f79b55a8fdd21b559e4f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","backport:version","v8.18.0","Feature:Streams"],"title":"[Streams] Make root stream selectively immutable","number":205609,"url":"https://github.com/elastic/kibana/pull/205609","mergeCommit":{"message":"[Streams] Make root stream selectively immutable (#205609)\n\n## Summary\r\n\r\nThis closes https://github.com/elastic/streams-program/issues/54.\r\n\r\nThe root stream is selectively immutable (processing and fields changes\r\nare not allowed).\r\n\r\n## UI\r\n\r\nFor the UI I've entirely disabled the actions column for the root stream\r\nin the schema editor. All of the information (bar the preview table for\r\nchanges) available in the flyout for a field is already available in the\r\ntable, so this seems easiest for now to avoid multiple logic forks\r\nwrapping buttons etc.\r\n\r\nE.g. flyout vs table\r\n\r\n","sha":"4ba5879fa932945004f0f79b55a8fdd21b559e4f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205609","number":205609,"mergeCommit":{"message":"[Streams] Make root stream selectively immutable (#205609)\n\n## Summary\r\n\r\nThis closes https://github.com/elastic/streams-program/issues/54.\r\n\r\nThe root stream is selectively immutable (processing and fields changes\r\nare not allowed).\r\n\r\n## UI\r\n\r\nFor the UI I've entirely disabled the actions column for the root stream\r\nin the schema editor. All of the information (bar the preview table for\r\nchanges) available in the flyout for a field is already available in the\r\ntable, so this seems easiest for now to avoid multiple logic forks\r\nwrapping buttons etc.\r\n\r\nE.g. flyout vs table\r\n\r\n","sha":"4ba5879fa932945004f0f79b55a8fdd21b559e4f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <[email protected]>
kibanamachine
removed
the
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary This closes elastic/streams-program#54. The root stream is selectively immutable (processing and fields changes are not allowed). ## UI For the UI I've entirely disabled the actions column for the root stream in the schema editor. All of the information (bar the preview table for changes) available in the flyout for a field is already available in the table, so this seems easiest for now to avoid multiple logic forks wrapping buttons etc. E.g. flyout vs table 
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary This closes elastic/streams-program#54. The root stream is selectively immutable (processing and fields changes are not allowed). ## UI For the UI I've entirely disabled the actions column for the root stream in the schema editor. All of the information (bar the preview table for changes) available in the flyout for a field is already available in the table, so this seems easiest for now to avoid multiple logic forks wrapping buttons etc. E.g. flyout vs table 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This closes https://github.com/elastic/streams-program/issues/54.
The root stream is selectively immutable (processing and fields changes are not allowed).
UI
For the UI I've entirely disabled the actions column for the root stream in the schema editor. All of the information (bar the preview table for changes) available in the flyout for a field is already available in the table, so this seems easiest for now to avoid multiple logic forks wrapping buttons etc.
E.g. flyout vs table