-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][THI] - replace usages of EUI vis colors #205218
Conversation
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that we no longer have background color of the group icons after migration, is it intended?
...lution/public/detections/components/alerts_table/grouping_settings/group_panel_renderers.tsx
Outdated
Show resolved
Hide resolved
...ins/security_solution/public/timelines/components/timeline/data_providers/provider_badge.tsx
Show resolved
Hide resolved
@angorayc yeah this is intentional. The background colors behind those icons made no sense to me. I'm not sure why they were added in the first place. Why would we have colors behind I just reached out to @codearos on Slack to make sure he is ok with this change. I will update the PR description to add this information once confirmed it's validated! |
9a69c3d
to
c6c3afc
Compare
no background color changes approved by @codearos! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Changes LGTM from EUI side.
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Summary
This PR is part of a list of PRs to perform the changes necessary to get the new Borealis theme working correctly. It focuses on replace the vis colors for non-visualization usages by correct EUI color tokens.
2 places have been impacted:
Host
User
Network
Dark mode
Light mode
The changes have been reviewed and approved by @codearos 😄
#201883