Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UX][EUI Visual Refresh] Update theme usage #202746

Merged
merged 18 commits into from
Dec 13, 2024
Merged

[Logs UX][EUI Visual Refresh] Update theme usage #202746

merged 18 commits into from
Dec 13, 2024

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Dec 3, 2024 •
edited
Loading

📓 Summary

Closes #202652
Closes #202653
Closes #202654
Closes #202656
Closes #202657
Closes #202658
Closes #202660

These changes close issues as part of a bigger effort to integrate the EUI changes.

This takes into account renaming success colour token to the more appropriate accentSecondary as specified by the guidelines, and updating legacy naming for tokens to the new respective names.

Also, it removes usages of the static euiThemeVars tokens and check for usages vis tokens.

@patpscal Let me know if something feels off, I checked how the colour render in the 4 theme combination (amsterdam/borealis + light/dark) and it looks good to me.

@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-logs Observability Logs User Experience Team EUI Visual Refresh labels Dec 3, 2024
@tonyghiani tonyghiani requested a review from a team as a code owner December 3, 2024 14:35
@tonyghiani tonyghiani requested a review from a team December 3, 2024 14:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@patpscal
Copy link

patpscal commented Dec 3, 2024

@patpscal Let me know if something feels off, I checked how the colour render in the 4 theme combination (amsterdam/borealis + light/dark) and it looks good to me.

Hi @tonyghiani, Could you please provide a direct link to the environment running with Borealis? It would be super helpful for our review. Thank you so much, we really appreciate it! c/ @kkurstak

@patpscal patpscal self-requested a review December 3, 2024 14:58
@tonyghiani
Copy link
Contributor Author

/oblt-deploy

@tonyghiani tonyghiani requested review from a team as code owners December 4, 2024 11:31
cauemarcondes
cauemarcondes approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes LGTM

@tonyghiani tonyghiani changed the title [Logs UX][EUI Visual Refresh] Update success tokens and renaming [Logs UX][EUI Visual Refresh] Update theme usage Dec 4, 2024
@tonyghiani tonyghiani requested a review from a team as a code owner December 4, 2024 15:07
@tonyghiani
Copy link
Contributor Author

/oblt-deploy

davismcphee
davismcphee approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review, Data Discovery changes LGTM 👍

@patpscal
Copy link

patpscal commented Dec 5, 2024 •
edited
Loading

Tested using
https://tkajtoch-pr-202746-202652-update-success-color-usages.kbndev.co/

I wasn't able to see any log data in logs-explorer - but other areas are correct.

dataset-quality
observability-onboarding

There is one discrepancy pending; I'm checking with EUI to see if it will be fixed on their end. More context Solved - Will be fixed in EUI's end.

@tonyghiani tonyghiani removed the request for review from a team December 12, 2024 12:09
mgadewoll
mgadewoll approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM from EUI side 👍

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 13, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 8925aa8
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202746-8925aa828afc

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / Configure updates field options correctly when not required

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
datasetQuality 276 277 +1
logsShared 362 376 +14
total +15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 252.0KB 252.4KB +410.0B
discover 786.0KB 786.0KB +32.0B
infra 1.8MB 1.8MB +1.8KB
logsExplorer 223.1KB 223.1KB +7.0B
logsShared 334.8KB 294.6KB -40.1KB
observabilityLogsExplorer 148.0KB 148.1KB +78.0B
unifiedDocViewer 115.9KB 115.8KB -74.0B
total -37.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 18.9KB 18.9KB -54.0B
logsShared 174.8KB 174.8KB -43.0B
observabilityLogsExplorer 15.2KB 15.2KB -54.0B
unifiedDocViewer 11.3KB 11.3KB +1.0B
total -150.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
logsShared 18 19 +1
observabilityLogsExplorer 1 2 +1
total +2

Total ESLint disabled count

id before after diff
logsShared 21 22 +1
observabilityLogsExplorer 1 2 +1
total +2

History

yngrdyn
yngrdyn approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyghiani tonyghiani merged commit 0ca6502 into elastic:main Dec 13, 2024
8 checks passed
@tonyghiani tonyghiani deleted the 202652-update-success-color-usages branch December 13, 2024 11:25
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@tonyghiani @kibanamachine @CAWilson94
[Logs UX][EUI Visual Refresh] Update theme usage (elastic#202746)
a1dec22 
## 📓 Summary

Closes elastic#202652
Closes elastic#202653 
Closes elastic#202654
Closes elastic#202656 
Closes elastic#202657 
Closes elastic#202658 
Closes elastic#202660 

These changes close issues as part of a bigger effort to integrate the
EUI changes.

This takes into account renaming `success` colour token to the more
appropriate `accentSecondary` as specified by the guidelines, and
updating legacy naming for tokens to the new respective names.

Also, it removes usages of the static `euiThemeVars` tokens and check
for usages `vis` tokens.

@patpscal Let me know if something feels off, I checked how the colour
render in the 4 theme combination (amsterdam/borealis + light/dark) and
it looks good to me.

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga left review comments

@patpscal patpscal patpscal approved these changes

@yngrdyn yngrdyn yngrdyn approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@davismcphee davismcphee davismcphee approved these changes

@mgadewoll mgadewoll mgadewoll approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Obs Logs UX][EUI Visual Refresh] Update usages of vis colors for non-visualization usage [Obs Logs UX][EUI Visual Refresh] Update All usage of color palette tokens and functions [Obs Logs UX][EUI Visual Refresh] Update references to renamed tokens have been updated to use the new token name [Obs Logs UX][EUI Visual Refresh] Update usages of "successText" colors have been updated to "textAccentSecondary" [Obs Logs UX][EUI Visual Refresh] Update usages of "success" colors have been updated to "accentSecondary" and "textAccentSecondary"
[Obs Logs UX][EUI Visual Refresh] Update usages of custom colors/function and replace with EUI color tokens [Obs Logs UX][EUI Visual Refresh] Update usages of JSON tokens
10 participants
@tonyghiani @elasticmachine @patpscal @yngrdyn @sebelga @shahzad31 @davismcphee @mgadewoll @cauemarcondes @kibanamachine