Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v95.7.0 #190346

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Upgrade EUI to v95.7.0 #190346

merged 6 commits into from
Aug 14, 2024

Conversation

cee-chen
Copy link
Contributor

v95.6.0v95.7.0

Questions? Please see our Kibana upgrade FAQ.


v95.7.0

CSS-in-JS conversions

  • Converted EuiSelectable to Emotion (#7940)
    • Removed $euiSelectableListItemBorder
    • Removed $euiSelectableListItemPadding
  • Converted EuiSelectableTemplateSitewide to Emotion (#7944)
    • Removed $euiSelectableTemplateFocusBackgroundLight
    • Removed $euiSelectableTemplateFocusBackgroundDark
    • Removed $euiSelectableTemplateSitewideTypes
  • Converted EuiComboBox to Emotion (#7950)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.16.0 labels Aug 12, 2024
- Emotion adds another wrapper, so we need to be more speciifc
… CSS

- the default `.euiSelectableList` className still exists and should work to target the element
…CSS applied to it

+ apply custom Emotion CSS directly instead
@cee-chen
Copy link
Contributor Author

/ci

@cee-chen cee-chen marked this pull request as ready for review August 12, 2024 22:52
@cee-chen cee-chen requested review from a team as code owners August 12, 2024 22:52
@cee-chen cee-chen requested a review from vitaliidm August 12, 2024 22:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cases changes OK

@cee-chen cee-chen enabled auto-merge (squash) August 14, 2024 16:12
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 480.2KB 480.2KB -9.0B
infra 1.5MB 1.5MB +324.0B
kubernetesSecurity 212.1KB 212.4KB +324.0B
maps 3.0MB 3.0MB +325.0B
securitySolution 20.7MB 20.7MB -9.0B
visTypeVega 1.8MB 1.8MB +324.0B
total +1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 191.3KB 178.4KB -12.8KB
kbnUiSharedDeps-npmDll 6.1MB 6.1MB +11.1KB
total -1.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 761f5e7 into elastic:main Aug 14, 2024
42 checks passed
@cee-chen cee-chen deleted the eui/v95.7.0 branch August 14, 2024 17:35
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants