Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Empty state for entities #188209

Merged
merged 9 commits into from
Jul 15, 2024
Merged

[APM] Empty state for entities #188209

merged 9 commits into from
Jul 15, 2024

Conversation

kpatticha
Copy link
Contributor

closes https://github.com/elastic/observability-dev/issues/3730, https://github.com/elastic/observability-dev/issues/3725

Summary

Smaller screens

Screenshot 2024-07-12 at 15 14 21

image

Screenshot 2024-07-12 at 15 18 02

Screen.Recording.2024-07-12.at.15.10.32.mov

Note

There is a bug for the horizonal layout: #188200

@kpatticha kpatticha requested a review from a team as a code owner July 12, 2024 12:20
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Jul 12, 2024
@kpatticha kpatticha requested a review from crespocarlos July 15, 2024 08:30
@kpatticha kpatticha enabled auto-merge (squash) July 15, 2024 08:54
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 15, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / CustomFields renders correctly

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1902 1904 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +3.3KB

History

@kpatticha kpatticha merged commit 765b231 into elastic:main Jul 15, 2024
23 of 24 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpatticha @elasticmachine @obltmachine @crespocarlos @kibanamachine