Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proofpoint_on_demand] - Added new advanced config options for blanket & infinite retries and updated default retry values #12419

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Jan 22, 2025

Type of change

  • Enhancement

Proposed commit message

Added new advanced config options for blanket & infinite retries while updating default retry values.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2025-01-22 at 11 18 01 AM

@ShourieG ShourieG requested a review from a team as a code owner January 22, 2025 05:10
@ShourieG ShourieG self-assigned this Jan 22, 2025
@andrewkroh andrewkroh added Integration:proofpoint_on_demand Proofpoint On Demand Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Jan 22, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added the enhancement New feature or request label Jan 22, 2025
@ShourieG ShourieG changed the title [proofpoint_on_demand] - Added new advanced config options for blanket & infinite retries while updating default retry values [proofpoint_on_demand] - Added new advanced config options for blanket & infinite retries and updated default retry values Jan 22, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package proofpoint_on_demand 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
mail 5000 3759.4 -1240.6 (-24.81%) 💔
message 1555.21 1264.22 -290.99 (-18.71%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @ShourieG

@ShourieG ShourieG requested review from kcreddy and removed request for kcreddy January 22, 2025 10:21
Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit b88f6cf into elastic:main Jan 22, 2025
5 checks passed
@ShourieG ShourieG deleted the enhancement/proof_on_demand branch January 22, 2025 12:43
@elastic-vault-github-plugin-prod

Package proofpoint_on_demand - 1.4.0 containing this change is available at https://epr.elastic.co/package/proofpoint_on_demand/1.4.0/

harnish-elastic pushed a commit to harnish-elastic/integrations that referenced this pull request Feb 4, 2025
…t & infinite retries and updated default retry values (elastic#12419)

* Added new advanced config options for blanket & infinite retries while updating default retry values.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
…t & infinite retries and updated default retry values (#12419)

* Added new advanced config options for blanket & infinite retries while updating default retry values.
harnish-elastic pushed a commit to harnish-elastic/integrations that referenced this pull request Feb 5, 2025
…t & infinite retries and updated default retry values (elastic#12419)

* Added new advanced config options for blanket & infinite retries while updating default retry values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:proofpoint_on_demand Proofpoint On Demand Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants