-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update elastic-agent-libs #4042
Conversation
This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
|
|
Needs a changelog for the mTLS certificate verification change at least, and anything else significant that has come in as part of this version bump. |
953b1b7
to
96d2199
Compare
the git push didn't go through, it's there now |
/test |
kind: feature | ||
|
||
# Change summary; a 80ish characters long description of the change. | ||
summary: Fleet Server uses 'ssl.verification_mode: certificate' by default for incomming client connections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is clear enough. Fleet Server's TLS certificate is a critical part of agent security. Explain why this was done and what the possible consequences are, in particular separate out the impact for mTLS and standard TLS if they are different.
The PR description here should also reflect what the actual change in elastic-agent-libs is, because there is only one elastic/elastic-agent-libs@4babafd We should also detail what testing has or needs to happen to make sure this doesn't break anything or regress TLS security accidentally. |
elastic-agent-libs v0.14.0 sets the server side certificate verification mode to 'certificate' by default
96d2199
to
16b38df
Compare
|
elastic-agent-libs v0.14.0 sets the server side certificate verification mode to 'certificate' by default (cherry picked from commit 7d77467) # Conflicts: # NOTICE.txt # go.mod # go.sum # testing/go.mod # testing/go.sum
elastic-agent-libs v0.14.0 sets the server side certificate verification mode to 'certificate' by default (cherry picked from commit 7d77467) # Conflicts: # NOTICE.txt # go.mod # go.sum # testing/go.mod # testing/go.sum
elastic-agent-libs v0.14.0 sets the server side certificate verification mode to 'certificate' by default (cherry picked from commit 7d77467) # Conflicts: # NOTICE.txt # go.mod # go.sum # testing/go.mod # testing/go.sum
elastic-agent-libs v0.14.0 sets the server side certificate verification mode to 'certificate' by default (cherry picked from commit 7d77467)
elastic-agent-libs v0.14.0 sets the server side certificate verification mode to 'certificate' by default (cherry picked from commit 7d77467)
elastic-agent-libs v0.14.0 sets the server side certificate verification mode to 'certificate' by default (cherry picked from commit 7d77467) Co-authored-by: Anderson Queiroz <[email protected]>
elastic-agent-libs v0.14.0 sets the server side certificate verification mode to 'certificate' by default (cherry picked from commit 7d77467) Co-authored-by: Anderson Queiroz <[email protected]>
What is the problem this PR solves?
fleet-server using an outdated version of elastic-agent-libs
How does this PR solve the problem?
by updating
elastic-agent-libs
ot its latest versionHow to test this PR locally
Ensure mTLS is still working
adjust the IPs/hostnames as needed
build a fleet-server out of this PR
you might need to build an 8.16 agent out of main:
add your fleet server built to the agent package
tar -xf elastic-agent-8.16.0-SNAPSHOT-linux-x86_64.tar.gz cp path/tp/your/fleet-server ./elastic-agent-8.16.0-SNAPSHOT-linux-x86_64/data/elastic-agent-*/components/fleet-server
create 2 TLS certificates
elastic-agent-libs/testing/certutil/cmd
to create the certificates. Make sure to useelastic-agent-libs
with this PR merged or use the PR branchfleet-server
or change-name fleet-server
to a valid DNS for your fleet-server.you should have:
start an elastic stack (considering elastic-cloud)
add a fleet server with mTLS
create a policy with Elastic Defend
add an agent to that policy
Design Checklist
[ ] I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.[ ] I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.[ ] I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragments
using the changelog toolRelated issues