Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Support new theme tokens on JSON exports #8277

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Jan 15, 2025

Summary

Important

This PR merges into a feature branch.

This PR introduces support for the new theme tokens that were added on euiTheme as well as SCSS variables already.
Initially our plan was to deprecate JSON token usage completely, which made the support for new tokens unnecessary.

But during the theme migration we noticed that there are use cases on Kibana where we can't remove the JSON token usage just yet and where the new tokens are required to support the new theme.

Note

Updating JSON tokens is currently still a manual process.

Changes

  • adds relevant new tokens for: backgrounds, borders, text, data vis
  • adds missing accentSecondary equivalents in Amsterdam
  • reorders the tokens a bit in the JSON files

QA

I'm afraid there is no nice way to QA this besides manual checks as those tokens are not in use 🙈
But I'm confident the update is correct as the update was done as follows:

  • copied euiTheme.colors output per theme and color mode and added relevant tokens to the JSON file (ensures correct color values)
  • added euiColor prefixes
  • rearranged tokens within the files (moving data vis colors further down right before generic color tokens)
  • ensured all 4 theme files have the same amount of tokens (420)

@mgadewoll mgadewoll self-assigned this Jan 15, 2025
@mgadewoll mgadewoll changed the base branch from main to eui-theme/borealis January 15, 2025 13:13
@mgadewoll mgadewoll marked this pull request as ready for review January 15, 2025 13:41
@mgadewoll mgadewoll requested a review from a team as a code owner January 15, 2025 13:41
Copy link
Member

@JasonStoltz JasonStoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment I left.

@mgadewoll mgadewoll requested a review from JasonStoltz January 16, 2025 09:26
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 17, 2025

💔 Build Failed

Failed CI Steps

History

cc @mgadewoll

@mgadewoll mgadewoll merged commit 305c92e into elastic:eui-theme/borealis Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants