[Visual Refresh] Support new theme tokens on JSON exports #8277
+2,102
−790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This PR merges into a feature branch.
This PR introduces support for the new theme tokens that were added on
euiTheme
as well as SCSS variables already.Initially our plan was to deprecate JSON token usage completely, which made the support for new tokens unnecessary.
But during the theme migration we noticed that there are use cases on Kibana where we can't remove the JSON token usage just yet and where the new tokens are required to support the new theme.
Note
Updating JSON tokens is currently still a manual process.
Changes
accentSecondary
equivalents in AmsterdamQA
I'm afraid there is no nice way to QA this besides manual checks as those tokens are not in use 🙈
But I'm confident the update is correct as the update was done as follows:
euiTheme.colors
output per theme and color mode and added relevant tokens to the JSON file (ensures correct color values)euiColor
prefixes