Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eui+] Fix docusaurus containerId for local environment #7938

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Aug 1, 2024

Summary

This PR ensures that Docusaurus can run locally as expected when no GTM containerId is available. This is a small update to the changes done in this PR.

This affects both dev environment and production build BUT locally only.
There is no issue with the production build in CI as the containerId is provided in the pipeline from the vault.

QA

  • checkout the PR and verify the website can be run locally without error
    • gh pr checkout 7938
    • go to /packages/website
    • install all local dependencies yarn workspaces foreach -Rpti --from @elastic/eui-website run build
    • start the local dev environment yarn start
    • build production locally and run it: yarn build && yarn serve

@mgadewoll mgadewoll force-pushed the eui+/fix-docusaurus-containerId branch from a29a88d to f53e501 Compare August 1, 2024 12:21
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mgadewoll mgadewoll marked this pull request as ready for review August 1, 2024 12:46
@mgadewoll mgadewoll requested a review from a team as a code owner August 1, 2024 12:46
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgadewoll mgadewoll merged commit 41293ac into elastic:main Aug 1, 2024
6 checks passed
@mgadewoll mgadewoll deleted the eui+/fix-docusaurus-containerId branch August 1, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants