Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix pattern tests in release builds (#120879) #120991

Merged
merged 2 commits into from
Jan 28, 2025
Merged

[8.x] Fix pattern tests in release builds (#120879) #120991

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5666aff
Fix pattern tests in release builds (#120879)
idegtiarenko Jan 28, 2025
70383e0
Merge branch '8.x' into backport/8.x/pr-120879
idegtiarenko Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...k/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2948,6 +2948,8 @@ public void testValidFromPattern() {
}

public void testValidJoinPattern() {
assumeTrue("LOOKUP JOIN requires corresponding capability", EsqlCapabilities.Cap.JOIN_LOOKUP_V12.isEnabled());

var basePattern = randomIndexPatterns(without(CROSS_CLUSTER));
var joinPattern = randomIndexPattern(without(WILDCARD_PATTERN), without(CROSS_CLUSTER));
var onField = randomIdentifier();
Expand All @@ -2965,6 +2967,8 @@ public void testValidJoinPattern() {
}

public void testInvalidJoinPatterns() {
assumeTrue("LOOKUP JOIN requires corresponding capability", EsqlCapabilities.Cap.JOIN_LOOKUP_V12.isEnabled());

{
// wildcard
var joinPattern = randomIndexPattern(WILDCARD_PATTERN, without(CROSS_CLUSTER));
Expand Down