Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Track in/out pages in exchange (#120867) #120943

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 27, 2025

Backports the following commits to 8.x:

This is a spin-off of the "retry node requests on shard-level failures" work.

Currently, a driver can execute against multiple shards simultaneously. 
If the execution fails and no pages are added to the sink, we can retry
the failed shards on another node. In another scenario, if no pages are
fetched or added to the exchange source and the entire data node request
fails, we can also retry the entire request. This change adds callbacks
to RemoteSink and ExchangeSink, allowing for tracking of in/out pages.
@dnhatn dnhatn added :Analytics/ES|QL AKA ESQL >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jan 27, 2025
@elasticsearchmachine elasticsearchmachine merged commit 08bacbb into elastic:8.x Jan 29, 2025
15 checks passed
@dnhatn dnhatn deleted the backport/8.x/pr-120867 branch January 29, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants