Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RequestIndexFilteringIT::testIndicesDontExist #120899

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

idegtiarenko
Copy link
Contributor

Remote cluster was randomly picked by the test. The failure was happening as now we emit a different error when attempting a join with a remote cluster.

Closes: #120889

Remote cluster was randomly picked by the test. The failure was happening as now we emit a different error when attempting a join with a remote cluster.
@idegtiarenko idegtiarenko added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Jan 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ievgen, just a minor suggestion otherwise LGTM!

@idegtiarenko idegtiarenko merged commit 084192c into elastic:main Jan 27, 2025
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 120899

@idegtiarenko idegtiarenko deleted the fix_120889 branch January 27, 2025 14:50
elasticsearchmachine pushed a commit that referenced this pull request Jan 27, 2025
Remote cluster is randomly picked by the test. The failure was happening as now we emit a different error when attempting a join with a remote cluster.

(cherry picked from commit 084192c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] RequestIndexFilteringIT testIndicesDontExist failing
3 participants