Fix pattern tests in release builds #120879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
commented
Jan 27, 2025
| @@ -2958,6 +2960,8 @@ public void testValidJoinPattern() { | |||
| } | |||
|
|
|||
| public void testInvalidJoinPatterns() { | |||
| assumeTrue("LOOKUP JOIN requires corresponding capability", EsqlCapabilities.Cap.JOIN_LOOKUP_V12.isEnabled()); | |||
There was a problem hiding this comment.
Please let me know if it is more preferable to rely on Build.current().isSnapshot() instead since JOIN_LOOKUP_V12 version is frequently incremented.
There was a problem hiding this comment.
I think this is fine/preferable. We have one main capability JOIN_LOOKUP_V12 and all related caps should be enabled or disabled based on this.
# Conflicts: # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java
alex-spies
approved these changes
Jan 27, 2025
| @@ -2958,6 +2960,8 @@ public void testValidJoinPattern() { | |||
| } | |||
|
|
|||
| public void testInvalidJoinPatterns() { | |||
| assumeTrue("LOOKUP JOIN requires corresponding capability", EsqlCapabilities.Cap.JOIN_LOOKUP_V12.isEnabled()); | |||
There was a problem hiding this comment.
I think this is fine/preferable. We have one main capability JOIN_LOOKUP_V12 and all related caps should be enabled or disabled based on this.
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testValidJoinPattern & testInvalidJoinPatterns are failing in release pipelines since corresponding feature is hidden behind the feature flag. Adding
assumeTrueto disable such tests in release builds until the feature is enabled.Closes: #120848
Closes: #120849